This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Proto3 optional field #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we planning to merge this pull request? |
|
Would be great if we could merge this pull request |
paullesiak
added a commit
to paullesiak/protoc-gen-go-json
that referenced
this pull request
Sep 19, 2022
|
This seems sufficient to me. The protojson package is doing the heavy lifting supporting optional, this really just needs to declare support |
|
@mitchellh any hesitations about merging this? |
|
This looks good thanks! Apologies for the delay. :) |
|
@mitchellh Please create a new tag |
|
Just ran into this problem while trying to use the Buf remote plugin. Unfortunately, Buf only releases updates for stable releases. Any chance this will be released soon? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables Marshalling and Unmarshalling the more recent proto3 optional fields capability.
Not thoroughly tested, I hope to use this on some non trivial messages before a merge is even considered.
Looking for feedback and suggestions.
Addresses #13