Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assignment instead of equality check? #20

Open
joydeep-b opened this issue Apr 20, 2019 · 2 comments
Open

Assignment instead of equality check? #20

joydeep-b opened this issue Apr 20, 2019 · 2 comments

Comments

@joydeep-b
Copy link

There are several lines such as:

vesc/vesc_driver/src/vesc_driver.cpp

Line 155 in 5127d60

if (driver_mode_ = MODE_OPERATING) {

I believe these should be:

  if (driver_mode_ == MODE_OPERATING) {
@dallinbriggs
Copy link

I agree with this.

@msadowski
Copy link

I also just came across this issue. If anyone is still maintaining this repo I'm happy to make a PR with a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dallinbriggs @joydeep-b @msadowski