This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
feat: add signal support and fix timeout, closes #5 #68
Merged
lerela
merged 6 commits into
mistralai:main
from
sublimator:nd-add-signal-support-and-fix-timeout-2024-05-01
May 6, 2024
+81
−33
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
74faf13
feat: add signal support and fix timeout, closes #5
sublimator de969ef
feat: add combineSignals
sublimator f7ae679
feat: update signal docs
sublimator 4b70df4
refactor: move signal from data to options
sublimator c9afae5
fix: set default option
sublimator 3ce76a0
feat: add node 22 to CI
sublimator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it might be worth considering whether to move
signal
into a second object param, and keep it out of the bag of data that is sent to the server. It's a bit cleaner that way.On a related note, I realised that the JSDoc comments are actually incorrect (see)