This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
feat: update fetch configuration logic #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sublimator
commented
Apr 30, 2024
| // We can't use a top level await if eventually this is to be converted | ||
| // to typescript and compiled to commonjs, or similarly using babel. | ||
| const configuredFetch = Promise.resolve( | ||
| globalThis.fetch ?? import('node-fetch').then((m) => m.default)); |
There was a problem hiding this comment.
Some credit to fuegoio here:
#65 (review)
fuegoio
approved these changes
Apr 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed version of #65 which was an exploration branch for a new version, including non-relevant commits
Closes:
Update fetch detection logic (See: #63 (comment)):
Use top level await, per here and here (this won't work in commonjs)