feat: Adjust navigation #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const router = useRouter(); | ||
|
|
||
| // Close menu manually | ||
| const [value, setValue] = useState(""); |
There was a problem hiding this comment.
value sound too generic. Is it possible to have some more speciifc name? smthng like currentMenuItem ?
| href={child.url as string} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| onClick={handleClick} |
There was a problem hiding this comment.
handleMenuItemClick ? to be more specific
wojtek007mirumee
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it adjust navigation:
Pull Request Checklist