Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locale issue #69

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix locale issue #69

merged 1 commit into from
Nov 8, 2024

Conversation

soniaklimas
Copy link
Contributor

I want to merge this change because it fixes locale issue - it adds a fallback mechanism to attempt fetching cms data with default locale if the initial locale retrieval fails.
It also renames cms attributes.

Pull Request Checklist

  • Test the changes locally to ensure they work as expected.
  • Document the testing process and results in the pull request description. (Screen recording, screenshot etc)
  • Include new tests for any new functionality or significant changes.
  • Ensure that tests cover edge cases and potential failure points.
  • Document the impact of the changes on the system, including potential risks and benefits.
  • Provide a rollback plan in case the changes introduce critical issues.
  • Update documentation to reflect any changes in functionality.

@soniaklimas soniaklimas self-assigned this Nov 8, 2024
Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nimara-ecommerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 11:59am

@soniaklimas soniaklimas merged commit c9b618d into develop Nov 8, 2024
3 checks passed
@soniaklimas soniaklimas deleted the MS-801-fix-locale-issue branch November 8, 2024 12:10
karolkarolka pushed a commit that referenced this pull request Dec 4, 2024
karolkarolka pushed a commit that referenced this pull request Dec 5, 2024
karolkarolka pushed a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants