feat: Integrate with Butter CMS #66

soniaklimas · 2024-11-04T10:07:30Z

I want to merge this change because it integrates with ButterCMS.

Pull Request Checklist

Test the changes locally to ensure they work as expected.
Document the testing process and results in the pull request description. (Screen recording, screenshot etc)
Include new tests for any new functionality or significant changes.
Ensure that tests cover edge cases and potential failure points.
Document the impact of the changes on the system, including potential risks and benefits.
Provide a rollback plan in case the changes introduce critical issues.
Update documentation to reflect any changes in functionality.

vercel · 2024-11-04T10:07:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nimara-ecommerce	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 8, 2024 10:28am

karolkarolka

I've could seen some of the functions being moved from one dir to another like serializers, but I think that you've removed some code related to Saleor CMS and we should keep it

karolkarolka · 2024-11-08T09:13:42Z

packages/infrastructure/src/public/saleor/cms-page/types.ts

@@ -1,23 +1,3 @@
-import type { LanguageCodeEnum } from "@nimara/codegen/schema";


why Saleor CMS types are being removed?

I just moved types related to use case to folder use-case (same as search case).

karolkarolka · 2024-11-08T09:15:17Z

packages/infrastructure/src/public/saleor/cms-page/index.ts

@@ -1,12 +0,0 @@
-import { cmsPageGetUseCase } from "#root/use-cases/cms-page/cms-page-get-use-case";


did you delete the Saleor CMS infra? I've thought about keeping ButterCMS and Saleor infra and using one or another depending of the needs

I just moved it to another file.

karolkarolka · 2024-11-08T09:16:49Z

packages/infrastructure/src/public/saleor/cms-menu/infrastructure/cms-menu-get-infra.ts

-} from "../graphql/queries/generated";
-import type { CMSMenuGetInfra, SaleorCMSMenuServiceConfig } from "../types";
-
-const serializeMenuItem = ({


isn't it still needed for Saleor CMS?

It is but I created separated file for serializers and move it there.

karolkarolka · 2024-11-08T09:17:47Z

apps/storefront/src/lib/helpers.ts

 import type { MenuItem } from "@nimara/domain/objects/Menu";
 import { loggingService } from "@nimara/infrastructure/logging/service";

-export const getAttributes = (


why it is being removed?

We do not use it anymore (there is new serializer which returns fields of cms data).

karolkarolka · 2024-11-08T09:20:34Z

packages/infrastructure/src/lib/serializers/cms-menu.ts

+      ? item.category[0].split("category[_id=")[1]?.split("]")[0] || ""
+      : "";
+
+    const category: Category | null = categoryId


Suggested change

const category: Category | null = categoryId

const category = categoryId

karolkarolka

one last very small change and you can merge

karolkarolka · 2024-11-08T10:23:05Z

packages/infrastructure/src/lib/serializers/cms-menu.ts

+      typeof item.page === "string"
+        ? item.page.split("/").filter(Boolean).pop() || ""
+        : "";
+    const page: Page | null = item.page


Suggested change

const page: Page | null = item.page

const page = item.page

wojtek007mirumee · 2024-11-08T13:32:02Z

packages/infrastructure/src/lib/serializers/cms-menu.ts

+  items: MenuGet_menu_Menu_items_MenuItem[] | ButterCMSMenuItem[],
+  source: "saleor" | "butterCms",
+): Menu => {
+  if (source === "saleor") {


To jest problem trochę. Powinniśmy używać kompozycji zamiast budować takie warunki.
Co myslisz o tym by stworzyć dwie funkcje: jedną dla saleor, drugą dla butter.
Wtedy jedna z nich moze byc uzyta w infrze buttera, a druga w infrze saleora.
Od poziomu infry powinnismy byc provider specifc, ale z wyraznym oddzieleniem kodu różnych providerów, by uniknąc tego ze zmiana dla jednego providera spowoduje bug dla drugiego.

wojtek007mirumee · 2024-11-08T13:32:50Z

packages/infrastructure/src/lib/serializers/cms-page.ts

+  fields: SelectionAttributeFragment[] | ButterCMSPageFields,
+  source: "saleor" | "butterCms",
+): PageField[] => {
+  if (source === "saleor") {


tak samo. Nigdzie nie powinnismy miec conditional z nazwą providera.

wojtek007mirumee · 2024-11-08T13:33:14Z

packages/infrastructure/src/public/butter-cms/cms-menu/infrastructure/cms-menu-get-infra.ts

+    );
+
+    return {
+      menu: serializeMenu(


Tutaj i tak jesteśmy w kontekscie providera.

feat: Integrate with Butter CMS

666be3a

soniaklimas added the WIP label Nov 4, 2024

soniaklimas self-assigned this Nov 4, 2024

Update pnpm-lock.yaml

3a7a385

vercel bot had a problem deploying to Preview November 4, 2024 10:12 Failure

Adjust infra to fetch static pages

34fa70f

vercel bot had a problem deploying to Preview November 4, 2024 14:24 Failure

Adjust infra to fetch menu

d648acc

vercel bot had a problem deploying to Preview November 6, 2024 11:50 Failure

Fix type error in menu infra

cb89ba5

vercel bot deployed to Preview November 6, 2024 15:05 View deployment

Remove any type

62fb13f

vercel bot deployed to Preview November 6, 2024 16:03 View deployment

soniaklimas removed the WIP label Nov 6, 2024

soniaklimas requested a review from karolkarolka November 6, 2024 16:05

karolkarolka requested changes Nov 8, 2024

View reviewed changes

Implement review

f80a6f1

vercel bot deployed to Preview November 8, 2024 09:51 View deployment

karolkarolka requested changes Nov 8, 2024

View reviewed changes

Implement review

b3ce352

soniaklimas requested a review from karolkarolka November 8, 2024 10:26

karolkarolka approved these changes Nov 8, 2024

View reviewed changes

vercel bot deployed to Preview November 8, 2024 10:28 View deployment

soniaklimas merged commit cf0fe2d into develop Nov 8, 2024
3 checks passed

soniaklimas deleted the MS-801-butter-cms-integration branch November 8, 2024 10:29

wojtek007mirumee reviewed Nov 8, 2024

View reviewed changes

karolkarolka pushed a commit that referenced this pull request Dec 4, 2024

feat: Integrate with Butter CMS (#66)

8c8dec3

karolkarolka pushed a commit that referenced this pull request Dec 5, 2024

feat: Integrate with Butter CMS (#66)

ea92e6d

karolkarolka pushed a commit that referenced this pull request Dec 5, 2024

feat: Integrate with Butter CMS (#66)

ebf7e92

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Integrate with Butter CMS #66

feat: Integrate with Butter CMS #66

soniaklimas commented Nov 4, 2024

vercel bot commented Nov 4, 2024 •

edited

Loading

karolkarolka left a comment •

edited

Loading

karolkarolka Nov 8, 2024

soniaklimas Nov 8, 2024

karolkarolka Nov 8, 2024

soniaklimas Nov 8, 2024

karolkarolka Nov 8, 2024

soniaklimas Nov 8, 2024

karolkarolka Nov 8, 2024

soniaklimas Nov 8, 2024

karolkarolka Nov 8, 2024

karolkarolka left a comment

karolkarolka Nov 8, 2024

wojtek007mirumee Nov 8, 2024

wojtek007mirumee Nov 8, 2024

wojtek007mirumee Nov 8, 2024

		@@ -1,23 +1,3 @@
		import type { LanguageCodeEnum } from "@nimara/codegen/schema";

		@@ -1,12 +0,0 @@
		import { cmsPageGetUseCase } from "#root/use-cases/cms-page/cms-page-get-use-case";

	const category: Category \| null = categoryId
	const category = categoryId

feat: Integrate with Butter CMS #66

feat: Integrate with Butter CMS #66

Conversation

soniaklimas commented Nov 4, 2024

Pull Request Checklist

vercel bot commented Nov 4, 2024 • edited Loading

karolkarolka left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karolkarolka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented Nov 4, 2024 •

edited

Loading

karolkarolka left a comment •

edited

Loading