Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Close search form after submitting #23

Merged
merged 3 commits into from
Oct 3, 2024
Merged

fix: Close search form after submitting #23

merged 3 commits into from
Oct 3, 2024

Conversation

soniaklimas
Copy link
Contributor

I want to merge this change because it closes search form after submission on mobile.

Pull Request Checklist

  • Test the changes locally to ensure they work as expected.
  • Document the testing process and results in the pull request description. (Screen recording, screenshot etc)
  • Include new tests for any new functionality or significant changes.
  • Ensure that tests cover edge cases and potential failure points.
  • Document the impact of the changes on the system, including potential risks and benefits.
  • Provide a rollback plan in case the changes introduce critical issues.
  • Update documentation to reflect any changes in functionality.

soniaklimas and others added 2 commits September 27, 2024 09:22
@soniaklimas
fix: Improve search experience (#18)
7924db7 
* fix: Improve search experience

* Search on icon click

* Add margin top to header when items in bag

* Use cn
@soniaklimas
fix: Close search form after submitting
39fbb44
@soniaklimas soniaklimas self-assigned this Oct 3, 2024
@soniaklimas soniaklimas changed the base branch from main to develop October 3, 2024 11:34
@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nimara-ecommerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 11:57am

@soniaklimas soniaklimas merged commit a1f1afd into develop Oct 3, 2024
3 checks passed
@soniaklimas soniaklimas deleted the MS-764-close-search-form branch October 3, 2024 12:28
karolkarolka pushed a commit that referenced this pull request Oct 25, 2024
@soniaklimas @karolkarolka
fix: Close search form after submitting (#23)
20f310a 
* fix: Improve search experience (#18)

* fix: Improve search experience

* Search on icon click

* Add margin top to header when items in bag

* Use cn

* fix: Close search form after submitting

* Make onSubmit optional
karolkarolka pushed a commit that referenced this pull request Oct 25, 2024
@soniaklimas @karolkarolka
fix: Close search form after submitting (#23)
dca17ea 
* fix: Improve search experience (#18)

* fix: Improve search experience

* Search on icon click

* Add margin top to header when items in bag

* Use cn

* fix: Close search form after submitting

* Make onSubmit optional
karolkarolka pushed a commit that referenced this pull request Oct 25, 2024
@soniaklimas @karolkarolka
fix: Close search form after submitting (#23)
ec6d36d 
* fix: Improve search experience (#18)

* fix: Improve search experience

* Search on icon click

* Add margin top to header when items in bag

* Use cn

* fix: Close search form after submitting

* Make onSubmit optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrgrundas piotrgrundas piotrgrundas approved these changes

Assignees

@soniaklimas soniaklimas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soniaklimas @piotrgrundas