feat: Initiate return process #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karolkarolka
requested changes
Nov 27, 2024
...ages/infrastructure/src/public/saleor/checkout/infrastructure/order-return-products-infra.ts
Outdated
Show resolved
Hide resolved
...ages/infrastructure/src/public/saleor/checkout/infrastructure/order-return-products-infra.ts
Outdated
Show resolved
Hide resolved
| @@ -25,6 +26,35 @@ type NextFetchOptions = { next?: { revalidate?: number; tags?: string[] } }; | |||
| export type FetchOptions = Omit<RequestInit, "method" | "body"> & | |||
| NextFetchOptions; | |||
|
|
|||
| export const secureSaleorClient = ({ | |||
There was a problem hiding this comment.
I'm not sure why you've copied the secureSaleorClient from storefront, what is wrong with the authorization in current graphql client in packages dir?
There was a problem hiding this comment.
I was misled by the more specific name - secureSaleorClient, which suggested it might have additional security features or enhancements. You are right - current GraphQL client in the packages already handles authorization correctly.
| .filter(([_, isSelected]) => isSelected) | ||
| .map(([lineId]) => ({ | ||
| orderLineId: lineId, | ||
| quantity: 0, // despite 0 correct qty from order is returned |
There was a problem hiding this comment.
why do you need to set quantity as 0?
karolkarolka
approved these changes
Nov 29, 2024
karolkarolka
pushed a commit
that referenced
this pull request
Dec 4, 2024
karolkarolka
pushed a commit
that referenced
this pull request
Dec 5, 2024
karolkarolka
pushed a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it implements initiation of return process.
Pull Request Checklist