Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set default locale without locale prefix in pathname #109

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

karolkarolka
Copy link
Collaborator

The default locale is now "en-US" assigned to the storefront domain without locale prefix ("/"), all other supported locales are accessible under prefixed locale pathname ("e.g. "/gb").

Pull Request Checklist

  • Test the changes locally to ensure they work as expected.
  • Document the testing process and results in the pull request description. (Screen recording, screenshot etc)
  • Include new tests for any new functionality or significant changes.
  • Ensure that tests cover edge cases and potential failure points.
  • Document the impact of the changes on the system, including potential risks and benefits.
  • Provide a rollback plan in case the changes introduce critical issues.
  • Update documentation to reflect any changes in functionality.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nimara-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 1:14pm
nimara-ecommerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 1:14pm

@soniaklimas
Copy link
Contributor

It resolved issue with checkout while changing locale, niceeee 🚀

@karolkarolka karolkarolka merged commit a91e041 into develop Dec 12, 2024
4 checks passed
@karolkarolka karolkarolka deleted the feat/MS-883-default-locale-region branch December 12, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants