Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct cms service #101

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Use correct cms service #101

merged 2 commits into from
Dec 5, 2024

Conversation

soniaklimas
Copy link
Contributor

I want to merge this change because allows to switching cms service through Vercel env.

Pull Request Checklist

  • Test the changes locally to ensure they work as expected.
  • Document the testing process and results in the pull request description. (Screen recording, screenshot etc)
  • Include new tests for any new functionality or significant changes.
  • Ensure that tests cover edge cases and potential failure points.
  • Document the impact of the changes on the system, including potential risks and benefits.
  • Provide a rollback plan in case the changes introduce critical issues.
  • Update documentation to reflect any changes in functionality.

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nimara-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 8:13am
nimara-ecommerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 8:13am

karolkarolka
karolkarolka requested changes Dec 4, 2024
View reviewed changes
apps/storefront/src/services/cms.ts Outdated Show resolved Hide resolved
karolkarolka
karolkarolka approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@karolkarolka karolkarolka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check before merging if setting CMS_SERVICE env on Vercel works on for your Preview build

@soniaklimas
Copy link
Contributor Author

I tested it and it works correctly - if you change CMS_SERVICE env on Vercel and do redeploy chosen CMS is used.

@soniaklimas soniaklimas merged commit 49b6941 into develop Dec 5, 2024
4 checks passed
@soniaklimas soniaklimas deleted the use-correct-cms-service branch December 5, 2024 08:16
soniaklimas added a commit that referenced this pull request Dec 5, 2024
@soniaklimas
Use correct cms service (#101)
87dbf62
karolkarolka pushed a commit that referenced this pull request Dec 5, 2024
@soniaklimas @karolkarolka
Use correct cms service (#101)
d34f751
karolkarolka pushed a commit that referenced this pull request Dec 5, 2024
@soniaklimas @karolkarolka
Use correct cms service (#101)
5d29850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karolkarolka karolkarolka karolkarolka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soniaklimas @karolkarolka