Fixes #1188 purge directives marked as repeatable #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of the failing tests appear to be specific to linting in areas this PR did not touch. How should I proceed with these? |
|
I opened #1198 to fix the linters. I can merge that back into here but wanted to get separate feedback on them. |
rafalp
requested changes
Nov 18, 2024
reallistic
force-pushed
the
repeatable_directives_in_federation
branch
from
091b9ed to
97458a7
Compare
|
Please rebase on main branch to fix build. |
reallistic
force-pushed
the
repeatable_directives_in_federation
branch
from
97458a7 to
bf2b330
Compare
rafalp
reviewed
Nov 19, 2024
Co-authored-by: Rafał Pitoń <[email protected]>
rafalp
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the regex used for purging directives from the sdl to include directives containing the
repeatabletag.Fixes #1188