Add execution context class to graphql kwargs #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalp
suggested changes
Mar 20, 2024
| @@ -14,8 +14,7 @@ | |||
| from ariadne.types import ContextValue, ErrorFormatter, ExtensionList, RootValue, ValidationRules | |||
|
|
|||
| from graphql import GraphQLSchema | |||
| from graphql.execution import MiddlewareManager | |||
| } | ||
|
|
||
| def get_context_for_request(self, request: HttpRequest) -> Optional[ContextValue]: | ||
| def get_context_for_request(self, request: HttpRequest, data=None) -> Optional[ContextValue]: |
| # From ariadne 0.20 Extension supports both sync and async contexts | ||
| # https://github.com/mirumee/ariadne/blob/main/CHANGELOG.md#020-2023-06-21 | ||
| from ariadne.types import Extension as ExtensionSync | ||
| from graphql import ExecutionContext, GraphQLBoolean, GraphQLResolveInfo, GraphQLScalarType |
There was a problem hiding this comment.
Suggested change
| from graphql import ExecutionContext, GraphQLBoolean, GraphQLResolveInfo, GraphQLScalarType | |
| from graphql import ExecutionContext, GraphQLBoolean, GraphQLResolveInfo, GraphQLScalarType |
Please format code with black.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ariadne 0.18 it is possible to change the execution context class. This makes it possible to use an execution context that supports deferred execution of dataloaders: https://github.com/jkimbo/graphql-sync-dataloaders
As ariadne-django has not been updated to ariadne 0.18 yet, it does not pass the
execution_context_classparameter to ariadne. I made some changes to add this to the list of arguments in get_kwargs_graphql.Since this would require at least ariadne 0.18, I increased the version of the dependency. I also made some small changes that were neccessary to get the tests to run with API changes in newer versions of ariande