Fix auth request

mirego · Aug 29, 2023 · cb1cfc0 · cb1cfc0
1 parent 942a3f3
commit cb1cfc0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/lib/accent/auth/uberauth/dummy_strategy.ex b/lib/accent/auth/uberauth/dummy_strategy.ex
@@ -3,7 +3,7 @@ defmodule Accent.Auth.Ueberauth.DummyStrategy do
   A username strategy for Ueberauth
   """
 
-  use Ueberauth.Strategy
+  use Ueberauth.Strategy, ignores_csrf_attack: true
 
   alias Ueberauth.Auth.Credentials
   alias Ueberauth.Auth.Extra

diff --git a/lib/accent/schemas/user.ex b/lib/accent/schemas/user.ex
@@ -28,7 +28,9 @@ defmodule Accent.User do
     "test"
     iex> Accent.User.name_with_fallback(%{fullname: nil, email: "[email protected]"})
     "[email protected]"
+    iex> Accent.User.name_with_fallback(%{fullname: "", email: "[email protected]"})
+    "[email protected]"
   """
-  def name_with_fallback(%{fullname: fullname, email: email}) when is_nil(fullname), do: email
+  def name_with_fallback(%{fullname: fullname, email: email}) when fullname in ["", nil], do: email
   def name_with_fallback(%{fullname: fullname}), do: fullname
 end
diff --git a/lib/web/controllers/auth_controller.ex b/lib/web/controllers/auth_controller.ex
@@ -7,7 +7,7 @@ defmodule Accent.AuthController do
   plug(Ueberauth, base_path: "/auth")
 
   def request(conn, _params) do
-    render(conn, "request.html", callback_url: Helpers.callback_url(conn))
+    redirect(conn, to: Helpers.callback_url(conn))
   end
 
   def callback(%{assigns: %{ueberauth_auth: auth}} = conn, _) do

diff --git a/webapp/app/pods/components/login-forms/styles.scss b/webapp/app/pods/components/login-forms/styles.scss
@@ -137,6 +137,10 @@ a.loginButton {
   border: 1px solid #888;
   font-size: 13px;
 
+  &:focus {
+    box-shadow: 0 3px 10px var(--shadow-color);
+  }
+
   &.loginButton--google {
     border-color: darken(#4d90fe, 5%);
     text-shadow: none;
@@ -169,6 +173,7 @@ a.loginButton {
     &:focus,
     &:hover {
       background: var(--background-light);
+      color: var(--text-color-normal);
     }
   }