Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConnectionProvider #5748

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Use ConnectionProvider #5748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions initialise/MirahezeFunctions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use MediaWiki\MediaWikiServices;
use Miraheze\CreateWiki\Services\RemoteWikiFactory;
use Miraheze\ManageWiki\Helpers\ManageWikiSettings;
use Wikimedia\Rdbms\DBConnRef;
use Wikimedia\Rdbms\IDatabase;
use Wikimedia\Rdbms\IReadableDatabase;

class MirahezeFunctions {
Expand Down Expand Up @@ -950,13 +950,11 @@ public function loadExtensions() {

/**
* @param string $databaseName
* @return DBConnRef
* @return IReadableDatabase
*/
private static function getDatabaseConnection( string $databaseName ): DBConnRef {
return MediaWikiServices::getInstance()
->getDBLoadBalancerFactory()
->getMainLB( $databaseName )
->getMaintenanceConnectionRef( DB_REPLICA, [], $databaseName );
private static function getDatabaseConnection( string $databaseName ): IReadableDatabase {
return MediaWikiServices::getInstance()->getConnectionProvider()
->getReplicaDatabase( $databaseName );
}

/**
Expand Down Expand Up @@ -1162,7 +1160,7 @@ public static function onManageWikiCoreAddFormFields( $ceMW, $context, $dbName,
/**
* @param IContextSource $context
* @param string $dbName
* @param DBConnRef $dbw
* @param IDatabase $dbw
* @param array $formData
* @param RemoteWikiFactory &$remoteWiki
*/
Expand Down
Loading