miraheze · paladox · Dec 17, 2023 · Dec 10, 2023 · Dec 10, 2023 · Dec 10, 2023
diff --git a/.github/workflows/mediawiki-tests.yml b/.github/workflows/mediawiki-tests.yml
@@ -12,15 +12,15 @@ jobs:
     strategy:
       matrix:
         include:
-          # Latest Old MediaWiki stable - PHP 7.4 
-          - mw: 'REL1_39'
+          # Latest MediaWiki stable - PHP 7.4
+          - mw: 'REL1_40'
             php: 7.4
             php-docker: 74
             composer-test: true
             experimental: false
 
-          # Latest MediaWiki stable - PHP 7.4 
-          - mw: 'REL1_40'
+          # Latest MediaWiki stable - PHP 7.4
+          - mw: 'REL1_41'
             php: 7.4
             php-docker: 74
             composer-test: true

diff --git a/.phan/config.php b/.phan/config.php
@@ -3,6 +3,8 @@
 $cfg = require __DIR__ . '/../vendor/mediawiki/mediawiki-phan-config/src/config.php';
 
 $cfg['suppress_issue_types'] = [
+	'PhanAccessMethodInternal',
+	'PhanUndeclaredStaticMethod',
 	'SecurityCheck-LikelyFalsePositive'
 ];
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,20 @@
 ## ChangeLog for RottenLinks
 
+### 2.0.0 (DD-MM-2023)
+* Redesign RottenLinks to not depend on a maintenance script
+* Changes how we count page usage on RottenLinks special page.
+  We directly gather this from externallinks table rather then
+  storing it ourselfs. Saves space and reduces complexity in getting it.
+* Requires MediaWiki 1.40 or higher and to have migrated externallinks using
+  migrateExternallinks maintenance script and to set
+  wgExternalLinksSchemaMigrationStage to SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_OLD.
+  Config is removed under MW 1.41+.
+* Add support for MediaWiki 1.41.
+* Fix some deprecated warnings in php 8.2.
+* Remove showing lastRun and runTime as these are no longer needed.
+  They didn't work very well to begin with.
+* Adds additional messages to qqq.json.
+
 ### 1.0.20 (10-01-2023)
 * SpecialRottenLinks: replace usage of deprecated wfGetDB()
 

diff --git a/extension.json b/extension.json
@@ -1,20 +1,24 @@
 {
 	"name": "RottenLinks",
-	"version": "1.0.20",
+	"version": "2.0.0",
 	"author": [
 		"John Lewis",
-		"Universal Omega"
+		"Universal Omega",
+		"Paladox"
 	],
 	"descriptionmsg": "rottenlinks-desc",
 	"license-name": "GPL-3.0-or-later",
 	"url": "https://github.com/miraheze/RottenLinks",
 	"type": "specialpage",
 	"requires": {
-		"MediaWiki": ">= 1.35.3"
+		"MediaWiki": ">= 1.40.0"
 	},
 	"SpecialPages": {
 		"RottenLinks": "SpecialRottenLinks"
 	},
+	"JobClasses": {
+		"RottenLinksJob": "RottenLinksJob"
+	},
 	"MessagesDirs": {
 		"RottenLinks": [
 			"i18n"
@@ -26,12 +30,16 @@
 	"AutoloadClasses": {
 		"RottenLinks": "includes/RottenLinks.php",
 		"RottenLinksHooks": "includes/RottenLinksHooks.php",
+		"RottenLinksJob": "includes/RottenLinksJob.php",
 		"RottenLinksPager": "includes/RottenLinksPager.php",
 		"SpecialRottenLinks": "includes/SpecialRottenLinks.php"
 	},
 	"Hooks": {
 		"LoadExtensionSchemaUpdates": [
-			"RottenLinksHooks::fnRottenLinksSchemaUpdates"
+			"RottenLinksHooks::onRottenLinksSchemaUpdates"
+		],
+		"LinksUpdateComplete": [
+			"RottenLinksHooks::onLinksUpdateComplete"
 		]
 	},
 	"config": {

diff --git a/i18n/de.json b/i18n/de.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Externer Link",
 	"rottenlinks-table-response": "HTTP-Antwort",
 	"rottenlinks-table-usage": "Seitenanzahl",
-	"rottenlinks-rundate": "Ausführungsdatum",
-	"rottenlinks-runtime": "Ausführungszeitraum",
 	"rottenlinks-showbad": "Lediglich fehlerhafte Links anzeigen",
 	"rottenlinks-statistics": "Statistiken zu den Links",
 	"rottenlinks-stats": "Statistiken anzeigen"

diff --git a/i18n/en.json b/i18n/en.json
@@ -11,8 +11,6 @@
 	"rottenlinks-table-external": "External Link",
 	"rottenlinks-table-response": "HTTP Response",
 	"rottenlinks-table-usage": "Page Usage",
-	"rottenlinks-rundate": "Script run date",
-	"rottenlinks-runtime": "Script execution time",
 	"rottenlinks-showbad": "Show rotten links only",
 	"rottenlinks-statistics": "Rotten Link Statistics",
 	"rottenlinks-stats": "Show link statistics"

diff --git a/i18n/fi.json b/i18n/fi.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Ulkoinen linkki",
 	"rottenlinks-table-response": "HTTP-vastaus",
 	"rottenlinks-table-usage": "Käyttö sivuilla",
-	"rottenlinks-rundate": "Skriptin suorituspäivä",
-	"rottenlinks-runtime": "Skriptin suoritusaika",
 	"rottenlinks-showbad": "Näytä vain huonot linkit",
 	"rottenlinks-statistics": "Ulkoisten linkkien toimivuustilasto",
 	"rottenlinks-stats": "Näytä linkkitilastot"

diff --git a/i18n/fr.json b/i18n/fr.json
@@ -11,8 +11,6 @@
 	"rottenlinks-table-external": "Lien externe",
 	"rottenlinks-table-response": "Réponse HTTP",
 	"rottenlinks-table-usage": "Utilisation de la page",
-	"rottenlinks-rundate": "Date d’exécution du script",
-	"rottenlinks-runtime": "Durée d’exécution du script",
 	"rottenlinks-showbad": "Afficher seulement les liens corrompus",
 	"rottenlinks-statistics": "Statistiques des liens corrompus",
 	"rottenlinks-stats": "Afficher les statistiques des liens"

diff --git a/i18n/he.json b/i18n/he.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "קישור חיצוני",
 	"rottenlinks-table-response": "תגובת HTTP",
 	"rottenlinks-table-usage": "שימוש בדף",
-	"rottenlinks-rundate": "תאריך הרצת הסקריפט",
-	"rottenlinks-runtime": "זמן ביצוע הסקריפט",
 	"rottenlinks-showbad": "הצג קישורים מתים בלבד",
 	"rottenlinks-statistics": "סטטיסטיקות קישורים מתים",
 	"rottenlinks-stats": "הצגת סטטיסטיקות קישורים"

diff --git a/i18n/hu.json b/i18n/hu.json
@@ -5,6 +5,5 @@
 		]
 	},
 	"rottenlinks": "Külső linkek állapota",
-	"rottenlinks-table-response": "HTTP-válasz",
-	"rottenlinks-rundate": "A szkript legutóbbi futtatása"
+	"rottenlinks-table-response": "HTTP-válasz"
 }
diff --git a/i18n/ia.json b/i18n/ia.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Ligamine externe",
 	"rottenlinks-table-response": "Responsa HTTP",
 	"rottenlinks-table-usage": "Uso del pagina",
-	"rottenlinks-rundate": "Data de execution del script",
-	"rottenlinks-runtime": "Durata de execution del script",
 	"rottenlinks-showbad": "Monstrar solmente le ligamines putrite",
 	"rottenlinks-statistics": "Statisticas de ligamines putrite",
 	"rottenlinks-stats": "Monstrar statisticas de ligamines"

diff --git a/i18n/ja.json b/i18n/ja.json
@@ -13,8 +13,6 @@
 	"rottenlinks-table-external": "外部リンク",
 	"rottenlinks-table-response": "HTTPレスポンス",
 	"rottenlinks-table-usage": "ページの使用状況",
-	"rottenlinks-rundate": "スクリプトが実行されて日時",
-	"rottenlinks-runtime": "スクリプトの実行時間",
 	"rottenlinks-showbad": "腐ったリンクのみを表示",
 	"rottenlinks-statistics": "腐ったリンクの統計",
 	"rottenlinks-stats": "リンクの統計を表示"

diff --git a/i18n/lt.json b/i18n/lt.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Išorinė nuoroda",
 	"rottenlinks-table-response": "HTTP atsakymas",
 	"rottenlinks-table-usage": "Puslapio naudojimas",
-	"rottenlinks-rundate": "Kodo vykdymo data",
-	"rottenlinks-runtime": "Kodo vykdymo trukmė",
 	"rottenlinks-showbad": "Rodyti tik sugedusias nuorodas",
 	"rottenlinks-statistics": "Sugedusių nuorodų statistika",
 	"rottenlinks-stats": "Rodyti nuorodų statistiką"

diff --git a/i18n/mk.json b/i18n/mk.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Надворешна врска",
 	"rottenlinks-table-response": "HTTP-одговор",
 	"rottenlinks-table-usage": "Употреба на страницата",
-	"rottenlinks-rundate": "Датум на пуштање",
-	"rottenlinks-runtime": "Време на исполнување",
 	"rottenlinks-showbad": "Прикажувај само расипани врски",
 	"rottenlinks-statistics": "Статистика за расипани врски",
 	"rottenlinks-stats": "Дај статистика за врски"

diff --git a/i18n/nl.json b/i18n/nl.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Externe koppeling",
 	"rottenlinks-table-response": "HTTP-antwoord",
 	"rottenlinks-table-usage": "Paginagebruik",
-	"rottenlinks-rundate": "Uitvoeringsdatum script",
-	"rottenlinks-runtime": "Uitvoeringstijd script",
 	"rottenlinks-showbad": "Alleen rotte links tonen",
 	"rottenlinks-statistics": "Statistieken over rotte links",
 	"rottenlinks-stats": "Linkstatistieken weergeven"

diff --git a/i18n/pl.json b/i18n/pl.json
@@ -11,8 +11,6 @@
 	"rottenlinks-table-external": "Link zewnętrzny",
 	"rottenlinks-table-response": "Odpowiedź HTTP",
 	"rottenlinks-table-usage": "Użycie na stronach",
-	"rottenlinks-rundate": "Data uruchomienia skryptu",
-	"rottenlinks-runtime": "Czas wykonania skryptu",
 	"rottenlinks-showbad": "Pokaż tylko zgniłe linki",
 	"rottenlinks-statistics": "Statystyki zgniłych linków",
 	"rottenlinks-stats": "Pokaż statystyki linków"

diff --git a/i18n/pt-br.json b/i18n/pt-br.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Link externo",
 	"rottenlinks-table-response": "Resposta HTTP",
 	"rottenlinks-table-usage": "Uso de página",
-	"rottenlinks-rundate": "Data de execução do script",
-	"rottenlinks-runtime": "Tempo de execução do script",
 	"rottenlinks-showbad": "Mostrar somente links quebrados",
 	"rottenlinks-statistics": "Estatísticas de link quebrado",
 	"rottenlinks-stats": "Mostrar estatísticas do link"

diff --git a/i18n/pt.json b/i18n/pt.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Hiperligação externa",
 	"rottenlinks-table-response": "Resposta HTTP",
 	"rottenlinks-table-usage": "Utilização da página",
-	"rottenlinks-rundate": "Data de execução do ''script''",
-	"rottenlinks-runtime": "Tempo de execução do ''script''",
 	"rottenlinks-showbad": "Mostrar só as hiperligações corrompidas",
 	"rottenlinks-statistics": "Estatísticas de hiperligações corrompidas",
 	"rottenlinks-stats": "Mostrar estatísticas das hiperligações"

diff --git a/i18n/qqq.json b/i18n/qqq.json
@@ -2,13 +2,16 @@
 	"@metadata": {
 		"authors": [
 			"John Lewis",
-			"Kghbln"
+			"Kghbln",
+			"Universal Omega"
 		]
 	},
-	"rottenlinks": "This is the title of Special:RottenLinks as well as the label of the link pointing to it on Special:SpecialPages",
-	"rottenlinks-desc": "This is the extension's despription on Special:Verion",
+	"rottenlinks": "{{doc-special}}",
+	"rottenlinks-desc": "{{desc|name=RottenLinks|url=https://github.com/miraheze/RottenLinks}}",
 	"rottenlinks-table-external": "This is the label of a tabel header on Special:RottenLinks",
 	"rottenlinks-table-response": "This is the label of a tabel header on Special:RottenLinks",
 	"rottenlinks-table-usage": "This is the label of a tabel header on Special:RottenLinks",
-	"rottenlinks-showbad": "This is the text describing a checkbox on Special:RottenLinks"
+	"rottenlinks-showbad": "This is the text describing a checkbox on Special:RottenLinks",
+	"rottenlinks-statistics": "This is the text of a form section on Special:RottenLinks",
+	"rottenlinks-stats": "This is the text describing a checkbox on Special:RottenLinks"
 }
diff --git a/i18n/ru.json b/i18n/ru.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Внешняя ссылка",
 	"rottenlinks-table-response": "HTTP-ответ",
 	"rottenlinks-table-usage": "Использование страницы",
-	"rottenlinks-rundate": "Дата выполнения скрипта",
-	"rottenlinks-runtime": "Время выполнения скрипта",
 	"rottenlinks-showbad": "Отобразить только гнилые ссылки",
 	"rottenlinks-statistics": "Статистика гнилых ссылок",
 	"rottenlinks-stats": "Отобразить статистику ссылок"

diff --git a/i18n/sh-cyrl.json b/i18n/sh-cyrl.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Вањски линк",
 	"rottenlinks-table-response": "HTTP-одговор",
 	"rottenlinks-table-usage": "Употреба странице",
-	"rottenlinks-rundate": "Датум покретања скрипте",
-	"rottenlinks-runtime": "Вријеме извршења скрипте",
 	"rottenlinks-showbad": "Прикажи само покварене линкове",
 	"rottenlinks-statistics": "Статистика покварених линкова",
 	"rottenlinks-stats": "Дај статистику линкова"

diff --git a/i18n/sh-latn.json b/i18n/sh-latn.json
@@ -11,8 +11,6 @@
 	"rottenlinks-table-external": "Vanjski link",
 	"rottenlinks-table-response": "HTTP-odgovor",
 	"rottenlinks-table-usage": "Upotreba stranice",
-	"rottenlinks-rundate": "Datum pokretanja skripte",
-	"rottenlinks-runtime": "Vrijeme izvršenja skripte",
 	"rottenlinks-showbad": "Prikaži samo pokvarene linkove",
 	"rottenlinks-statistics": "Statistika pokvarenih linkova",
 	"rottenlinks-stats": "Daj statistiku linkova"

diff --git a/i18n/sl.json b/i18n/sl.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Zunanja povezava",
 	"rottenlinks-table-response": "HTTP-odgovor",
 	"rottenlinks-table-usage": "Uporaba strani",
-	"rottenlinks-rundate": "Datum izvedbe skripta",
-	"rottenlinks-runtime": "Čas izvedbe skripta",
 	"rottenlinks-showbad": "Pokaži samo nedelujoče povezave",
 	"rottenlinks-statistics": "Statistika nedelujočih povezav",
 	"rottenlinks-stats": "Prikaži statistiko povezav"

diff --git a/i18n/sv.json b/i18n/sv.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "Extern länk",
 	"rottenlinks-table-response": "HTTP-respons",
 	"rottenlinks-table-usage": "Sidanvändning",
-	"rottenlinks-rundate": "Skriptkörningsdatum",
-	"rottenlinks-runtime": "Skriptuförningstid",
 	"rottenlinks-showbad": "Visa bara döda länkar",
 	"rottenlinks-statistics": "Statistik över döda länkar",
 	"rottenlinks-stats": "Visa länkstatistik"

diff --git a/i18n/tr.json b/i18n/tr.json
@@ -11,8 +11,6 @@
 	"rottenlinks-table-external": "Dış Bağlantı",
 	"rottenlinks-table-response": "HTTP Yanıtı",
 	"rottenlinks-table-usage": "Sayfa Kullanımı",
-	"rottenlinks-rundate": "Komut dosyası çalıştırma tarihi",
-	"rottenlinks-runtime": "Komut dosyası yürütme süresi",
 	"rottenlinks-showbad": "Yalnızca bozuk bağlantıları göster",
 	"rottenlinks-statistics": "Bozuk Bağlantı İstatistikleri",
 	"rottenlinks-stats": "Bağlantı istatistiklerini göster"

diff --git a/i18n/zh-hans.json b/i18n/zh-hans.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "外部链接",
 	"rottenlinks-table-response": "HTTP响应",
 	"rottenlinks-table-usage": "页面使用情况",
-	"rottenlinks-rundate": "脚本运行日期",
-	"rottenlinks-runtime": "脚本执行时间",
 	"rottenlinks-showbad": "仅显示错误链接",
 	"rottenlinks-statistics": "错误链接统计信息",
 	"rottenlinks-stats": "显示链接统计信息"

diff --git a/i18n/zh-hant.json b/i18n/zh-hant.json
@@ -10,8 +10,6 @@
 	"rottenlinks-table-external": "外部連結",
 	"rottenlinks-table-response": "HTTP 回應",
 	"rottenlinks-table-usage": "頁面使用情況",
-	"rottenlinks-rundate": "腳本運作日期",
-	"rottenlinks-runtime": "腳本執行時間",
 	"rottenlinks-showbad": "只顯示損壞連結",
 	"rottenlinks-statistics": "損壞連結統計",
 	"rottenlinks-stats": "顯示連結統計"

diff --git a/includes/RottenLinksHooks.php b/includes/RottenLinksHooks.php
@@ -1,10 +1,33 @@
 <?php
 
+use MediaWiki\MediaWikiServices;
+
 class RottenLinksHooks {
+	/**
+	 * Handler for LinksUpdateComplete hook.
+	 * @see https://www.mediawiki.org/wiki/Manual:Hooks/LinksUpdateComplete
+	 * @param LinksUpdate $linksUpdate
+	 * @param mixed $ticket
+	 */
+	public static function onLinksUpdateComplete( $linksUpdate, $ticket ) {
+		$addedExternalLinks = $linksUpdate->getAddedExternalLinks();
+		$removedExternalLinks = $linksUpdate->getRemovedExternalLinks();
+
+		if ( $addedExternalLinks || $removedExternalLinks ) {
+			$params = [
+				'addedExternalLinks' => $addedExternalLinks,
+				'removedExternalLinks' => $removedExternalLinks
+			];
+			MediaWikiServices::getInstance()->getJobQueueGroup()->push(
+				new RottenLinksJob( $params )
+			);
+		}
+	}
+
 	/**
 	 * @param DatabaseUpdater $updater
 	 */
-	public static function fnRottenLinksSchemaUpdates( DatabaseUpdater $updater ) {
+	public static function onRottenLinksSchemaUpdates( DatabaseUpdater $updater ) {
 		$updater->addExtensionTable( 'rottenlinks',
 			__DIR__ . '/../sql/rottenlinks.sql' );
 
@@ -13,5 +36,8 @@ public static function fnRottenLinksSchemaUpdates( DatabaseUpdater $updater ) {
 
 		$updater->addExtensionIndex( 'rottenlinks', 'rl_externallink',
 			__DIR__ . '/../sql/patches/20210215.sql' );
+
+		$updater->dropExtensionField( 'rottenlinks', 'rl_pageusage',
+			__DIR__ . '/../sql/patches/patch-drop-rl_pageusage.sql' );
 	}
 }