irmin-pack: Cleanup GC code prior to file split #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metanivek
reviewed
Oct 5, 2022
Ngoguey42
force-pushed
the
split-gc-file
branch
2 times, most recently
from
ecc77f0
to
6e1c7db
Compare
icristescu
reviewed
Oct 6, 2022
|
Thanks, LGTM! |
icristescu
approved these changes
Oct 6, 2022
metanivek
approved these changes
Oct 6, 2022
`transfer_append_exn` in GC.
Ngoguey42
force-pushed
the
split-gc-file
branch
from
6e1c7db
to
d1b74ab
Compare
|
Merge when green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@metanivek In the end I prefered reimplementing
read_bytes_exnbecauseread_in_prefix_and_suffix_exnwas not checking that the read in prefix was validI didn't add new tests for
read_bytes_exnbut #2092 still tracks this problem.Please propose alternatives names for
read_bytes_exn