Do not use symlink when writing and reading log files. #353
Conversation
|
Regression introduced in 44e1f1b |
|
gentle ping |
|
Hi @hhugo, the PR looks sensible. Because I'm not familiar with alcotest I writing out how I think this fixes #272 If I understand correctly, the race condition is that when two test suites with the same name are run concurrently, we get the following folders:
When writing to or reading from the log files, the symlink path was used, but as it is updated one of the test suites run will point to the wrong path. The PR fixes it by using the concrete path (using the uuid) instead for read/write operations. |
There was a problem hiding this comment.
Thank you for this PR.
My only complaints are that two CI jobs are failing:
- the changelog check: please add an entry to the changelog
- formatting: https://ci.ocamllabs.io/github/mirage/alcotest/commit/2ca9839096d92deaa24c426af35dd5fed7916b09/variant/(lint-fmt)
|
I've added a changelog entry and formatted the code. |
|
Thanks for merging. When should I expect a release with this change ? |
|
The plan is to get a release soon enough, I'd like to see some of the maintenance-related PRs merged first, in particular: @craigfe: I'm willing to take care of this if that's okay for you ! |
|
#348 would also be nice. It will likely break packages on opam and will require adding constraints. |
Fix #272