Fix tests about the output of alcotest (revert the controversial chan…

…ge about the newline for pp_summary)
mirage · Oct 13, 2023 · f690bde · f690bde
1 parent 7f3862d
commit f690bde
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/alcotest-engine/core.ml b/src/alcotest-engine/core.ml
@@ -363,9 +363,11 @@ module Make (P : Platform.MAKER) (M : Monad.S) = struct
            too. We don't need to register a channel even if the user specify its own
            [Format.formatter] for [stdout] and/or [stderr]. *)
         flush_all ();
-        Fmt.(pf (t.stderr :> Format.formatter))
-          "%a\n" red
-          "Invalid request (no tests to run, filter skipped everything)!";
+        Fmt.(
+          pf
+            (Global.get_stderr () :> Format.formatter)
+            "%a\n%!" red
+            "Invalid request (no tests to run, filter skipped everything)!");
         exit 1)
       else
         let tests = filter_test_cases ~subst:true filter suite in

diff --git a/src/alcotest-engine/pp.ml b/src/alcotest-engine/pp.ml
@@ -212,7 +212,7 @@ struct
       | 0 -> green_s ppf "Test Successful"
       | n -> red ppf "%d failure%a!" n pp_plural n
     in
-    Fmt.pf ppf "%a in %.3fs. %d test%a run.@\n" pp_failures r.failures r.time
+    Fmt.pf ppf "%a in %.3fs. %d test%a run.@," pp_failures r.failures r.time
       r.success pp_plural r.success
 
   let suite_results ~log_dir config ppf r =