Fix testing: add flush() to the Tee class #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Tee class is used as stdout-like object, but
it was missing the flush method. That method is called
by some code which is replaced by instances of Tee,
leading to errors:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "<...>/tests/test_options.py", line 94, in test_old_var_compatibility
p.program('export', {'--template': 'foobar-%s-1234.pot'})
[...]
File "/usr/lib/python3/dist-packages/colorama/ansitowin32.py", line 177, in write
self.write_and_convert(text)
File "/usr/lib/python3/dist-packages/colorama/ansitowin32.py", line 202, in write_and_convert
self.write_plain_text(text, cursor, start)
File "/usr/lib/python3/dist-packages/colorama/ansitowin32.py", line 211, in write_plain_text
self.wrapped.flush()
^^^^^^^^^^^^^^^^^^
AttributeError: 'Tee' object has no attribute 'flush'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tee class is used as stdout-like object, but
it was missing the flush method. That method is called by some code which is replaced by instances of Tee, leading to errors:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "<...>/tests/test_options.py", line 94, in test_old_var_compatibility
p.program('export', {'--template': 'foobar-%s-1234.pot'})
[...]
File "/usr/lib/python3/dist-packages/colorama/ansitowin32.py", line 177, in write
self.write_and_convert(text)
File "/usr/lib/python3/dist-packages/colorama/ansitowin32.py", line 202, in write_and_convert
self.write_plain_text(text, cursor, start)
File "/usr/lib/python3/dist-packages/colorama/ansitowin32.py", line 211, in write_plain_text
self.wrapped.flush()
^^^^^^^^^^^^^^^^^^
AttributeError: 'Tee' object has no attribute 'flush'