Skip to content

Commit

Permalink
Add new lints for flutter 3.0.4 and metrics 4.16.0 (#4)
Browse files Browse the repository at this point in the history
* Add new lints for flutter 3.0.4 and metrics 4.16.0
  • Loading branch information
paulkastel authored Jul 5, 2022
1 parent 6a66aa8 commit 869c062
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 5 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.2.4

* Lints from dart_metrics version 4.16.0
* Lints for Flutter 3.0.4

## 0.2.0

* Lints from dart_metrics version 4.15.2
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ We tested current configuration with this environment:
```yaml
environment:
sdk: ">=2.17.0 <3.0.0"
flutter: ^3.0.0
flutter: ^3.0.4
```
so it is required to update your flutter project to meet this conditions.
Expand All @@ -43,7 +43,7 @@ dev_dependencies:

or

you can copy content of [this file](lib/miquido_lints.yaml) to your `analysis_options.yaml`. In this approach remember that you need to depend on `dart_code_metrics: 4.15.2`, and you will need to add that package to your `pubspec.yaml` as well. Also you will need to visit this repository from time to time to check for changes!
you can copy content of [this file](lib/miquido_lints.yaml) to your `analysis_options.yaml`. In this approach remember that you need to depend on `dart_code_metrics: 4.16.0`, and you will need to add that package to your `pubspec.yaml` as well. Also you will need to visit this repository from time to time to check for changes!

Also if you star this repo, that would be nice.

Expand Down
2 changes: 2 additions & 0 deletions lib/miquido_lints.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ linter:
# to execute run `flutter analyze`. It should show "No issues found!" message.
dart_code_metrics:
rules:
# - avoid_restricted_imports - this would be good for modular projects and packages
- avoid-collection-methods-with-unrelated-types
# - avoid-dynamic - as much as we would love to have it, sometimes it is necessary
- avoid-global-state
Expand Down Expand Up @@ -306,6 +307,7 @@ dart_code_metrics:
- avoid-wrapping-in-padding
# - prefer-const-border-radius - proposed solution is adding extra code complexity for meaningless profit
- prefer-extracting-callbacks:
allowed-line-count: 0
ignored-named-arguments:
- listener
- listenWhen
Expand Down
6 changes: 3 additions & 3 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
name: miquido_flutter_lints
description: Collection of Flutter lints that we use and follow in Miquido
version: 0.2.0
version: 0.2.4
homepage: https://www.miquido.com

environment:
sdk: ">=2.17.0 <3.0.0"
flutter: ^3.0.0
flutter: ^3.0.4

dependencies:
dart_code_metrics: 4.15.2
dart_code_metrics: 4.16.0

flutter:
sdk: flutter
Expand Down

0 comments on commit 869c062

Please sign in to comment.