Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added connection between rules of the same ruleset #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ckosmowski
Copy link
Contributor

If more then one rules in a ruleset affects the same control, the rules should be connected in some way. For now i connected them with "AND" operator so every rule affecting a control must be true to make the control visible. Otherwise it will be hidden. This allows constructing more complex rules on the same level.

ckosmowski and others added 3 commits July 3, 2013 10:25
- Fixed passing parameters to evalCondition
- Fixed the control parameter of the call to evalCondition (this.control did not exist).
…le rules affect a control, every rule must be true to make the control visible
@miohtama
Copy link
Owner

Hi. This code looks good. Would it be possible to contribute related changes to documentation or examples, so that there would be an example how this all should work?

@tbtalbottjr
Copy link

This would be a great improvement. Is there any way to move this forward. Adding 'OR' would be great as well.

@javierciccarelli
Copy link

This is not working well.

@miohtama
Copy link
Owner

@javierciccarelli Care to clarify?

@javierciccarelli
Copy link

Yes, sorry, I was in a rush and I couldn't finish.

The && seems to work but when I switch it to || it is not working as I should expect.

If you have two rules and both of them do a .include() on the same element, it will only work for the second one, not the first one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants