Finalize UZI PoC Q4 for YubiSign project #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cbcec30.
|
Before this pull request can be ready for review, these should be merged first: |
Key reset on RSA page
Check PKCS library before starting up the application
basvandriel
changed the title
Co-authored-by: Rick Lambrechts <[email protected]>
Co-authored-by: Rick Lambrechts <[email protected]>
Co-authored-by: Rick Lambrechts <[email protected]>
Merged
|
Hi @ricklambrechts, find the applied feedback in this PR #60 |
Apply feedback from Rick
* work * add variable to .env.example * Update docs/local_setup.md Co-authored-by: Rick Lambrechts <[email protected]> --------- Co-authored-by: Rick Lambrechts <[email protected]>
Comment on lines
+130
to
+155
| san = x509.GeneralNames( | ||
| [ | ||
| x509.GeneralName("dns_name", "example.com"), | ||
| x509.GeneralName("dns_name", "www.example.com"), | ||
| ] | ||
| ) | ||
| extensions = [ | ||
| csr_module.CRIAttribute( | ||
| { | ||
| "type": "extension_request", | ||
| "values": [ | ||
| x509.Extensions( | ||
| [ | ||
| x509.Extension( | ||
| { | ||
| "extn_id": "subject_alt_name", | ||
| "critical": False, | ||
| "extn_value": san, | ||
| } | ||
| ) | ||
| ] | ||
| ) | ||
| ], | ||
| } | ||
| ) | ||
| ] |
There was a problem hiding this comment.
This should normally not be needed for our CSR, but is needed for the implementation in ACME CA Server.
| ) | ||
| headers = { | ||
| "Content-Type": "application/jose+json", | ||
| "X-Acme-Jwt": jwt_token, |
There was a problem hiding this comment.
Normally the JWT is already sent as a challenge and we should not need to update the finalize request.
|
Need to discuss #59 (comment) and #59 (comment) with @meneerhenk to discuss what we want to do with it. These changes conflict with changing between the ACME CA Server implementation and the Boulder implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request finalizes the Q4 PoC of the Yubisign application. This includes new features and refactoring. Note: this application is not suitable for any production environment.