Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_report_runner.py #4003

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Conversation

originalsouth
Copy link
Contributor

@originalsouth originalsouth commented Jan 1, 2025

Changes

Fix a test where the year was hard-coded and just broke today

Issue link

N/A

Demo

N/A

QA notes

CI should be enough.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@originalsouth originalsouth requested a review from a team as a code owner January 1, 2025 14:43
@originalsouth originalsouth added bug Something isn't working rocky Issues related to Rocky tech-debt labels Jan 1, 2025
@originalsouth originalsouth changed the title Fix test_report_runner.py for the next 974 years Fix test_report_runner.py Jan 1, 2025
Copy link

sonarqubecloud bot commented Jan 1, 2025

@underdarknl underdarknl merged commit 39130d0 into main Jan 1, 2025
22 checks passed
@underdarknl underdarknl deleted the fix/fix-test-report-runner-for-974-years branch January 1, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rocky Issues related to Rocky tech-debt
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants