Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs target in Makefile #3987

Merged
merged 4 commits into from
Dec 25, 2024
Merged

Fix docs target in Makefile #3987

merged 4 commits into from
Dec 25, 2024

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented Dec 24, 2024

Changes

This PR fixes the docs target when used on a Mac machine that doesn't have CoreUtils installed.

QA notes

  • Run make docs on a Linux machine and verify there are no build errors
  • Run make docs on a Mac machine and verify there are no build errors

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

dependabot bot and others added 3 commits December 23, 2024 11:57
@dependabot
Bump croniter from 5.0.1 to 6.0.0
9da2977 
Bumps [croniter](https://github.com/kiorky/croniter) from 5.0.1 to 6.0.0.
- [Changelog](https://github.com/kiorky/croniter/blob/master/CHANGELOG.rst)
- [Commits](corpusops/croniter@5.0.1...6.0.0)

---
updated-dependencies:
- dependency-name: croniter
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@ammar92
Updated requirements
e188a9e
@ammar92
Implemented fix for Mac compatibility
51a3b41
@ammar92 ammar92 added bug Something isn't working documentation Improvements or additions to documentation tech-debt labels Dec 24, 2024
@ammar92 ammar92 requested a review from a team as a code owner December 24, 2024 12:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@underdarknl underdarknl merged commit c00fe8a into main Dec 25, 2024
29 checks passed
@underdarknl underdarknl deleted the fix/make-docs branch December 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underdarknl underdarknl underdarknl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation tech-debt
Projects
KAT
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammar92 @underdarknl