Add env var for logging level #3751
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ammar92
reviewed
Oct 31, 2024
| key.split("BOEFJE_", 1)[1]: value | ||
| for key, value in os.environ.items() | ||
| if key.startswith("BOEFJE_") and key in allowed_keys | ||
| key[7:]: value for key, value in os.environ.items() if key.startswith("BOEFJE_") and key[7:] not in allowed_keys |
There was a problem hiding this comment.
new_env = {key.removeprefix("BOEFJE_"): value for key, value in os.environ.items() if key.startswith("BOEFJE_") and key.removeprefix("BOEFJE_") not in allowed_keys}
ammar92
reviewed
Oct 31, 2024
| @@ -48,6 +48,7 @@ class Settings(BaseSettings): | |||
| debug: bool = Field(False, alias="DEBUG", description="Enables/disables global debugging mode") | |||
|
|
|||
| log_cfg: Path = Field(BASE_DIR / "logging.json", description="Path to the logging configuration file") | |||
| log_level: str = Field("INFO", description="Logging level") | |||
There was a problem hiding this comment.
Suggested change
| log_level: str = Field("INFO", description="Logging level") | |
| log_level: Literal["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"] = Field("INFO", description="Logging level") |
ammar92
reviewed
Oct 31, 2024
Comment on lines
+45
to
+51
| # Set the logging level to the value specified by the env var | ||
| level = logging.getLevelName(self.config.log_level.upper()) | ||
| root_logger = logging.getLogger() | ||
| root_logger.setLevel(level) | ||
| root_logger.handlers[0].setLevel(level) | ||
| logging.getLogger("uvicorn.access").setLevel(level) | ||
| logging.getLogger("uvicorn.error").setLevel(level) |
There was a problem hiding this comment.
As mentioned offline and maybe for later: we could extend the dict config with this, so we'd have a consistent way of loading the logging configuration and printing out the logging configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add env variable for logging level. Work in progress, created PR so containers are build.
Issue link
You have to create an issue to link to this PR. If this really is not possible, write a very detailed description here and add this PR to the project board directly.
Please add the link to the issue after "Closes".
Closes ...
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.