Feat/security legacy urls #2556

underdarknl · 2024-02-26T08:39:02Z

Changes

Based on the RFC websites must have a .well-known/security.txt an not just a /security.txt file
This adds a finding for those sites.

Code Checklist

All the commits in this PR are properly PGP-signed and verified.
This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
I have written unit tests for the changes or fixes I made.
For any non-trivial functionality, I have added integration and/or end-to-end tests.
I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
I have made corresponding changes to the documentation, if necessary.
I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

boefjes/boefjes/plugins/kat_security_txt_downloader/normalize.py

…curity location

…nly.json

sonarqubecloud · 2024-06-03T14:33:05Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

boefjes/boefjes/plugins/kat_security_txt_downloader/main.py

underdarknl added 5 commits February 22, 2024 15:59

alert on legacy security.txt locations.

d5941ac

Update normalize.py

bedbbe5

fix host header not being set for non https urls in main.py

166e62e

add useragent to boefje.json

2bcc07b

Update kat_finding_types.json, add legacy security_txt location

e6f969f

underdarknl requested a review from a team as a code owner February 26, 2024 08:39

underdarknl added 4 commits February 26, 2024 09:50

linting normalize.py

acbe491

Update kat_finding_types.json

1701d4b

Update normalize.py

83fbb71

Merge branch 'main' into feat/security-legacy-urls

27265f4

underdarknl added the boefjes Issues related to boefjes label Feb 26, 2024

Donnype assigned underdarknl Feb 27, 2024

dekkers reviewed Feb 29, 2024

View reviewed changes

boefjes/boefjes/plugins/kat_security_txt_downloader/normalize.py Outdated Show resolved Hide resolved

fix legacy url check in normalize.py

3f17ff6

ammar92 previously approved these changes Mar 12, 2024

View reviewed changes

dekkers mentioned this pull request Mar 12, 2024

Add fix-byte-order-marker and pretty-format-json to pre-commit #2634

Merged

Merge branch 'main' into feat/security-legacy-urls

be3674f

underdarknl dismissed ammar92’s stale review via be3674f March 13, 2024 14:12

underdarknl added 12 commits March 13, 2024 15:26

Create missing security_txt bit.py

a97c534

Create missing_security_txt.py

65db495

Update report.py to handle missing security.txt finding and legacy se…

a60532d

…curity location

Create __init__.py

847e070

Update bit.py linting

fa47316

Update missing_security_txt.py linting

9471edb

Update missing_security_txt.py

6101e32

Update bit.py

8986326

Update missing_security_txt.py

3369ea4

Update report.py

d7dceea

Update report.py

c569e45

Update test_web_systems_report.py

1c4acc3

underdarknl added 27 commits May 3, 2024 10:03

linting security_txt_legacy-only.json

d1ea058

linting security_txt_result_no_file.json

77c2661

linting main.py

96ec478

linting normalize.py

63c5f0f

Update test_sucurity_txt.py

08d720c

Update and rename test_sucurity_txt.py to test_security_txt.py

8645670

Rename security_txt_legacy-only.json to security_txt_results_legacy_o…

d141857

…nly.json

Update security_txt_results_legacy_only.json

55ea05b

Update security_txt_result_no_file.json

2501a68

Update main.py

b970158

Update normalize.py

f638b07

Update test_security_txt.py

c40b024

lint test_security_txt.py

1a76913

Update test_security_txt.py

c0d6bc4

Update main.py

66bc846

Update normalize.py

50028d1

Update security_txt_result_no_file.json

e77541a

Update security_txt_results_legacy_only.json

a8dd860

Update test_security_txt.py

c3725ff

Update security_txt_results_legacy_only.json

1e94dcc

Update test_security_txt.py

c55ce43

Merge branch 'main' into feat/security-legacy-urls

0a78b16

Update test_security_txt.py

d4aab32

Update test_security_txt.py

9590a46

Update test_security_txt.py

04ee3e2

Update test_security_txt.py

b2d466c

Merge branch 'main' into feat/security-legacy-urls

e4b06ca

github-advanced-security bot found potential problems Jun 3, 2024

View reviewed changes

boefjes/boefjes/plugins/kat_security_txt_downloader/main.py Dismissed Show dismissed Hide dismissed

Merge branch 'main' into feat/security-legacy-urls

d87c1c8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/security legacy urls #2556

Feat/security legacy urls #2556

underdarknl commented Feb 26, 2024 •

edited

Loading

sonarqubecloud bot commented Jun 3, 2024 •

edited

Loading

Feat/security legacy urls #2556

Are you sure you want to change the base?

Feat/security legacy urls #2556

Conversation

underdarknl commented Feb 26, 2024 • edited Loading

Changes

Code Checklist

Communication

sonarqubecloud bot commented Jun 3, 2024 • edited Loading

Quality Gate passed

underdarknl commented Feb 26, 2024 •

edited

Loading

sonarqubecloud bot commented Jun 3, 2024 •

edited

Loading