Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative: Add task events to the scheduler #2214

Closed
wants to merge 5 commits into from

Conversation

jpbruinsslot
Copy link
Contributor

@jpbruinsslot jpbruinsslot commented Dec 28, 2023

Changes

This PR add task events functionality to the scheduler.

  1. Tracks status change events for tasks
  2. Allows and adds information about the task lifetime with new fields: queued (how long was the task on the queue), runtime (how long did the taskrunner take), duration (how long total time of processing of the task from creation to finalization). These new fields are exposed by the api. Since these fields are @computed_field we can also opt for adding these to their own jsonb field if these values regularly need to be queried.
  3. events field added to Task, and is also exposed by the api, such that events (status change events for now) can be inspected through the api.

Changes to initial PR (#2043)

  1. Adds a task events table, instead of an abstracted events table
  2. Only inserts in tasks events table on specific events, in this case only on status change events (post_push, post_pop, patch_task)
  3. Entire task object is not persisted in a jsonb field, only specific field for the event, in case of status change from_status, to_status

* main:
  Add less verbose logging and introduce structured logging in the scheduler (#2143)
  Remove default setting of id to None (#2166)
  Web and system report integration testing (#2203)
  Download report JSON and ReportData OOI (#2205)
  Fixes sidemenu animation and behaviour (#2192)
  Feat/clearance level trail (#2202)
  Add scheduler stats to boefje/normaliser task pages in rocky. (#2204)
  Fix/ooi detail improvements (#2201)
  Translations update from Hosted Weblate (#2148)
  Add a request model for push endpoint in scheduler (#2169)
  fix rpki delete_on_close, can be just delete (#2170)
  Increases gap between items within dl (#2193)
@jpbruinsslot jpbruinsslot self-assigned this Dec 28, 2023
@jpbruinsslot jpbruinsslot linked an issue Jan 2, 2024 that may be closed by this pull request
@jpbruinsslot jpbruinsslot added the mula Issues related to the scheduler label Jan 2, 2024
* main:
  Updated deploy-pages action (#2251)
  Bump msgpackr from 1.6.1 to 1.10.1 in /rocky (#2219)
  Add note about Debian packages to 1.14 release notes (#2234)
  Upgrade GitHub actions (#2235)
  Remove RPKI data files (#2228)
  Add 1.14 release notes (#2227)
  remove feature flag for reports. (#2226)
  Add multi organization report (#2209)
  Preselected OOIs for Reporting (#2208)
  Text changes OOI into Object (#2224)
  Adds the option to add chapter letters (#2225)
  Fix typos in aggregate report (#2168)
  Alert icons (#2221)
  Fix health endpoint scheduler (#2218)
  Table captions (#2217)
  Initial version of aggregate report appendix (#2212)
  add html entities escaping to normalizer results (#2211)
  Pdf and print styling (#2206)
  Adding recommendations to the aggregate report (#2210)
@jpbruinsslot jpbruinsslot marked this pull request as ready for review January 2, 2024 13:15
@jpbruinsslot jpbruinsslot requested a review from a team as a code owner January 2, 2024 13:15
@jpbruinsslot
Copy link
Contributor Author

Closing in favor of #2451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mula Issues related to the scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task events for scheduler
1 participant