Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default to granian #1987

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Switch default to granian #1987

merged 5 commits into from
Nov 13, 2023

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Nov 1, 2023

Changes

This PR switches the default to granian for 1.14. We keep uwsgi installed so it still possible to switch back in case of problems. Uwsgi will be removed in 1.15.

Issue link

Closes #1183


Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@dekkers dekkers requested a review from a team as a code owner November 1, 2023 15:28
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ammar92
Copy link
Contributor

ammar92 commented Nov 8, 2023

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

  • Seems to work on my end. Although I haven't tested the Debian packages

@underdarknl underdarknl merged commit c59fee1 into main Nov 13, 2023
22 checks passed
@underdarknl underdarknl deleted the switch-to-granian branch November 13, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

uWSGI can cause bad gateway error when scaling down number of workers
3 participants