Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java db to trivy job #2874

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Add java db to trivy job #2874

merged 1 commit into from
Oct 16, 2024

Conversation

gillettmoj
Copy link
Contributor

@gillettmoj gillettmoj commented Oct 15, 2024

Purpose

Pull java db in trivy job

Fixes UML-3653

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@gillettmoj gillettmoj requested a review from a team as a code owner October 15, 2024 12:21
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (f00760a) to head (6a6f211).
Report is 97 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2874      +/-   ##
============================================
+ Coverage     91.25%   91.64%   +0.39%     
- Complexity     1504     1624     +120     
============================================
  Files           309      345      +36     
  Lines          6393     6802     +409     
============================================
+ Hits           5834     6234     +400     
- Misses          542      551       +9     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 79.26% <ø> (ø)
use-an-lpa-api 97.64% <ø> (+0.27%) ⬆️
use-an-lpa-front 89.35% <ø> (-0.19%) ⬇️

see 2 files with indirect coverage changes

@gillettmoj gillettmoj merged commit 258c6dd into main Oct 16, 2024
31 checks passed
@gillettmoj gillettmoj deleted the uml-3653-trivy-java branch October 16, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants