Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uml 3620 rework resolve actor #2866

Merged
merged 26 commits into from
Oct 9, 2024
Merged

Conversation

allenannom
Copy link
Contributor

@allenannom allenannom commented Oct 9, 2024

Purpose

Reworked resolve actor to accept entity/siriuslpa (combined format) added tests for that as well

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

…itory-layer'

# Conflicts:
#	service-api/app/src/App/src/Service/Lpa/ResolveActor/SiriusHasActorTrait.php
# Conflicts:
#	service-api/app/test/AppTest/Entity/CanHydrateLpaStoreToModerniseFormatTest.php
@allenannom allenannom requested a review from a team as a code owner October 9, 2024 09:07
@github-actions github-actions bot added php Pull requests that update Php code service-api labels Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (f00760a) to head (ba6b7a0).
Report is 88 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2866      +/-   ##
============================================
+ Coverage     91.25%   91.64%   +0.39%     
- Complexity     1504     1624     +120     
============================================
  Files           309      345      +36     
  Lines          6393     6802     +409     
============================================
+ Hits           5834     6234     +400     
- Misses          542      551       +9     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 79.26% <ø> (ø)
use-an-lpa-api 97.64% <100.00%> (+0.27%) ⬆️
use-an-lpa-front 89.35% <ø> (-0.19%) ⬇️
Files with missing lines Coverage Δ
...c/Service/Lpa/ResolveActor/SiriusHasActorTrait.php 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@allenannom allenannom merged commit 712e885 into main Oct 9, 2024
34 checks passed
@allenannom allenannom deleted the UML-3620-rework-resolve-actor branch October 9, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update Php code service-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants