Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3622 rework trust corporations #2854

Merged
merged 24 commits into from
Oct 8, 2024
Merged

Conversation

nickdavis2001
Copy link
Contributor

@nickdavis2001 nickdavis2001 commented Oct 8, 2024

Purpose

_Rework GetTrustCorporationStatus with new combined objects _

Approach

Use combined objects, extend tests to cover both Sirius and LpaStore , implement necessary interface functions

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@nickdavis2001 nickdavis2001 marked this pull request as ready for review October 8, 2024 09:51
@nickdavis2001 nickdavis2001 requested a review from a team as a code owner October 8, 2024 09:51
@github-actions github-actions bot added php Pull requests that update Php code service-api labels Oct 8, 2024
@nickdavis2001 nickdavis2001 changed the title UML-3622 rework trust corporations UML-3622 rework trust corporations WIP DO NOT MERGE needs fixing Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (f00760a) to head (4f19eaf).
Report is 81 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2854      +/-   ##
============================================
+ Coverage     91.25%   91.64%   +0.38%     
- Complexity     1504     1624     +120     
============================================
  Files           309      345      +36     
  Lines          6393     6799     +406     
============================================
+ Hits           5834     6231     +397     
- Misses          542      551       +9     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 79.26% <ø> (ø)
use-an-lpa-api 97.64% <100.00%> (+0.27%) ⬆️
use-an-lpa-front 89.35% <ø> (-0.19%) ⬇️
Files with missing lines Coverage Δ
.../src/Entity/LpaStore/LpaStoreTrustCorporations.php 100.00% <100.00%> (ø)
...p/src/Entity/Sirius/SiriusLpaTrustCorporations.php 96.87% <100.00%> (ø)
.../App/src/Service/Lpa/GetTrustCorporationStatus.php 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@nickdavis2001 nickdavis2001 changed the title UML-3622 rework trust corporations WIP DO NOT MERGE needs fixing UML-3622 rework trust corporations Oct 8, 2024
@nickdavis2001 nickdavis2001 merged commit 8e753df into main Oct 8, 2024
34 checks passed
@nickdavis2001 nickdavis2001 deleted the UML-3622-trust-corp-status branch October 8, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update Php code service-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants