-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UML-3622 rework trust corporations #2854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itory-layer' # Conflicts: # service-api/app/src/App/src/Service/Lpa/ResolveActor/SiriusHasActorTrait.php
…ormat-repository-layer
…ormat-repository-layer
nickdavis2001
changed the title
UML-3622 rework trust corporations
UML-3622 rework trust corporations WIP DO NOT MERGE needs fixing
Oct 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2854 +/- ##
============================================
+ Coverage 91.25% 91.64% +0.38%
- Complexity 1504 1624 +120
============================================
Files 309 345 +36
Lines 6393 6799 +406
============================================
+ Hits 5834 6231 +397
- Misses 542 551 +9
Partials 17 17
|
nickdavis2001
changed the title
UML-3622 rework trust corporations WIP DO NOT MERGE needs fixing
UML-3622 rework trust corporations
Oct 8, 2024
allenannom
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
_Rework GetTrustCorporationStatus with new combined objects _
Approach
Use combined objects, extend tests to cover both Sirius and LpaStore , implement necessary interface functions
Checklist