Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3589: fix workspace deletion #2767

Merged
merged 2 commits into from
Sep 6, 2024
Merged

UML-3589: fix workspace deletion #2767

merged 2 commits into from
Sep 6, 2024

Conversation

jay-whitwell
Copy link
Contributor

Purpose

Updates the data parse workspace to correctly parse workspace names

Fixes UML-3589

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@jay-whitwell jay-whitwell requested a review from a team as a code owner September 6, 2024 12:43
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (f00760a) to head (f9cdf42).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2767      +/-   ##
============================================
+ Coverage     91.25%   91.29%   +0.03%     
- Complexity     1504     1515      +11     
============================================
  Files           309      311       +2     
  Lines          6393     6421      +28     
============================================
+ Hits           5834     5862      +28     
  Misses          542      542              
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 79.26% <ø> (ø)
use-an-lpa-api 97.39% <ø> (+0.02%) ⬆️
use-an-lpa-front 89.54% <ø> (ø)

@jay-whitwell jay-whitwell merged commit c446e0a into main Sep 6, 2024
30 checks passed
@jay-whitwell jay-whitwell deleted the UML-3589 branch September 6, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants