Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destroy on merge workflow #2757

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Add destroy on merge workflow #2757

merged 4 commits into from
Sep 4, 2024

Conversation

gillettmoj
Copy link
Contributor

@gillettmoj gillettmoj commented Aug 28, 2024

Purpose

Briefly describe the purpose of the change, and/or link to the JIRA ticket for context

Fixes UML-####

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@gillettmoj gillettmoj requested a review from a team as a code owner August 28, 2024 14:22
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (f00760a) to head (f4be019).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2757      +/-   ##
============================================
+ Coverage     91.25%   91.28%   +0.03%     
- Complexity     1504     1512       +8     
============================================
  Files           309      310       +1     
  Lines          6393     6416      +23     
============================================
+ Hits           5834     5857      +23     
  Misses          542      542              
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 79.26% <ø> (ø)
use-an-lpa-api 97.39% <ø> (+0.02%) ⬆️
use-an-lpa-front 89.54% <ø> (ø)

@gillettmoj gillettmoj changed the title Update workflow name Add destroy on merge workflow Aug 28, 2024
@gillettmoj gillettmoj force-pushed the uml-3454-destroy-on-merge branch from c9ddbce to f4be019 Compare September 4, 2024 09:24
@gillettmoj gillettmoj merged commit 84e04e9 into main Sep 4, 2024
30 checks passed
@gillettmoj gillettmoj deleted the uml-3454-destroy-on-merge branch September 4, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants