UML-3460 Return LPA store LPAs via the new endpoint in the new format #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
============================================
+ Coverage 91.25% 91.45% +0.20%
- Complexity 1504 1537 +33
============================================
Files 309 326 +17
Lines 6393 6543 +150
============================================
+ Hits 5834 5984 +150
Misses 542 542
Partials 17 17
|
…-endpoint-in-new-format
…heritance for the entities to help structure datastore and for future sirius implementation
cooperaj
reviewed
Sep 2, 2024
service-api/app/src/App/src/Entity/Casters/DateToStringSerializer.php
Outdated
Show resolved
Hide resolved
| */ | ||
| public function __invoke(array $lpa) | ||
| { | ||
| $defaultSerializerRepository = new DefaultSerializerRepository([ |
There was a problem hiding this comment.
Using interfaces for the dates might make this bit redundant?
There was a problem hiding this comment.
I don't think the DateTimeInterface setup is needed now?
cooperaj
reviewed
Sep 3, 2024
service-api/app/src/App/src/Entity/Casters/DateToStringSerializer.php
Outdated
Show resolved
Hide resolved
cooperaj
reviewed
Sep 3, 2024
cooperaj
reviewed
Sep 3, 2024
…-endpoint-in-new-format
created new files for dedicated tests
…-endpoint-in-new-format
cooperaj
reviewed
Sep 4, 2024
| #[Test] | ||
| public function can_serialise_datastore_lpa_to_modernise_format(): void | ||
| { | ||
| $lpa = json_decode(file_get_contents(__DIR__ . '../../../../test/fixtures/test_lpa.json'), true); |
There was a problem hiding this comment.
This is a Sirius LPA I think?
There was a problem hiding this comment.
ahh yeah it is.. my bad
There was a problem hiding this comment.
Might be better to just link directly to one from the mock. If tests breaks because someone changes those in development thats a good thing.
cooperaj
reviewed
Sep 4, 2024
| @@ -4,14 +4,34 @@ | |||
|
|
|||
| namespace AppTest\Service\Lpa; | |||
|
|
|||
| use App\Entity\Casters\{ | |||
There was a problem hiding this comment.
Are these imports used anymore?
|
Just realised the Person entity appears to be missing the uid field? |
…tests, and removed unused imports
…-endpoint-in-new-format # Conflicts: # service-api/app/test/AppTest/Service/Lpa/LpaServiceTest.php
cooperaj
reviewed
Sep 5, 2024
| class Person | ||
| { | ||
| public function __construct( | ||
| public readonly ?string $uId, |
There was a problem hiding this comment.
The LPA seems to have properties in alphabetical order but this one (and it's extensions) don't?
allenannom
deleted the
UML-3460-return-lpa-store-via-new-endpoint-in-new-format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Returning LPA store LPAs via the new endpoint in the new format
Learning
The use of a new library to map incoming data store LPA array using https://github.com/EventSaucePHP/ObjectHydrator
Checklist