Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3510 Set System Message in Admin #2724

Merged
merged 10 commits into from
Jul 30, 2024
Merged

UML-3510 Set System Message in Admin #2724

merged 10 commits into from
Jul 30, 2024

Conversation

Lbagg1
Copy link
Contributor

@Lbagg1 Lbagg1 commented Jul 24, 2024

Purpose

current behaviour:

Clearing system message and selecting set system message in admin portal is not removing system message from service and seeing error “error updating system message”
Expected behaviour:

Given there is no text in both the English and Welsh message box for Use message
And there is no text in either the English or Welsh message box for View message
And I select set system message
And i will see a flash message “system message has been removed”
Then no message will be in data store

Fixes UML-3510

Checklist

  • I have performed a self-review of my own code
  • I have added tests to prove my work
  • The product team have tested these changes

@github-actions github-actions bot added go Pull requests that update Go code service-admin labels Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (ee45e51) to head (d563d59).
Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2724      +/-   ##
============================================
- Coverage     91.14%   91.13%   -0.01%     
  Complexity     1497     1497              
============================================
  Files           306      307       +1     
  Lines          6312     6308       -4     
============================================
- Hits           5753     5749       -4     
  Misses          542      542              
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 79.26% <100.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rvice-admin/internal/server/data/ssm_connection.go 50.00% <ø> (ø)
...rvice-admin/internal/server/data/system_message.go 100.00% <100.00%> (ø)
...ce-admin/internal/server/handlers/systemmessage.go 100.00% <100.00%> (ø)

@Lbagg1 Lbagg1 marked this pull request as ready for review July 26, 2024 12:10
@Lbagg1 Lbagg1 requested a review from a team as a code owner July 26, 2024 12:10
Copy link
Contributor

@cooperaj cooperaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great!

Get UAT signoff and it's good to go.

@Lbagg1 Lbagg1 merged commit 1aef366 into main Jul 30, 2024
31 checks passed
@Lbagg1 Lbagg1 deleted the uml-3510-system-message-bug branch July 30, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code service-admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants