Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3110 Admin Portal - measuring impact tab update #2443

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

Lbagg1
Copy link
Contributor

@Lbagg1 Lbagg1 commented Nov 22, 2023

Purpose

The LPAs added does not show the real number. it shows 1.074101e+06

Please update so that it can be readable to the naked eye.

Apply this to all fields on this table.

Display totals - these are totals since the service began - or count began

Acceptance criteria

All numbers in admin portal measuring impact tab to show as human readable “numbers”

Display numbers in total column - total since service began.

Fixes UML-3110

Approach

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #2443 (b096f39) into main (a4bfc51) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2443      +/-   ##
============================================
- Coverage     91.88%   91.84%   -0.05%     
+ Complexity     1467     1421      -46     
============================================
  Files           279      274       -5     
  Lines          6653     6410     -243     
============================================
- Hits           6113     5887     -226     
+ Misses          523      506      -17     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 88.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 64 files with indirect coverage changes

@Lbagg1 Lbagg1 marked this pull request as ready for review November 22, 2023 11:45
@Lbagg1 Lbagg1 requested a review from a team as a code owner November 22, 2023 11:45
@Lbagg1 Lbagg1 merged commit 89a9723 into main Nov 22, 2023
28 checks passed
@Lbagg1 Lbagg1 deleted the uml-3110-admin-portal-display branch November 22, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants