Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML 2906 Running PHPcs/PHPcbf on Service Front #2396

Closed
wants to merge 32 commits into from

Conversation

Lbagg1
Copy link
Contributor

@Lbagg1 Lbagg1 commented Nov 2, 2023

Purpose

Run phpcbf (phpcs fixer) to fix code in service-front . Ensure everything still works.

Fixes UML-2906

Approach

Learning

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2396 (cef9da7) into main (be17a46) will decrease coverage by 0.09%.
The diff coverage is 82.40%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2396      +/-   ##
============================================
- Coverage     92.03%   91.95%   -0.09%     
  Complexity     1463     1463              
============================================
  Files           279      279              
  Lines          6655     6821     +166     
============================================
+ Hits           6125     6272     +147     
- Misses          513      532      +19     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 88.81% <ø> (ø)
use-an-lpa-api 96.84% <ø> (+0.06%) ⬆️
use-an-lpa-front 89.18% <82.40%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nt/app/src/Actor/src/Form/AddLpa/ActivationKey.php 100.00% <ø> (ø)
...ront/app/src/Actor/src/Form/AddLpa/DateOfBirth.php 100.00% <ø> (ø)
...p/src/Actor/src/Form/AddLpa/LpaReferenceNumber.php 100.00% <ø> (ø)
...vice-front/app/src/Actor/src/Form/AddLpaTriage.php 100.00% <100.00%> (ø)
...ervice-front/app/src/Actor/src/Form/CancelCode.php 100.00% <100.00%> (+100.00%) ⬆️
...rvice-front/app/src/Actor/src/Form/ChangeEmail.php 100.00% <100.00%> (ø)
...ice-front/app/src/Actor/src/Form/CreateAccount.php 100.00% <100.00%> (ø)
service-front/app/src/Actor/src/Form/Login.php 100.00% <100.00%> (ø)
...ervice-front/app/src/Actor/src/Form/LpaConfirm.php 0.00% <ø> (ø)
...ce-front/app/src/Actor/src/Form/PasswordChange.php 100.00% <100.00%> (ø)
... and 86 more

@Lbagg1 Lbagg1 closed this Nov 7, 2023
@Lbagg1 Lbagg1 deleted the uml-2906-run-phpcs-service-front branch November 7, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant