Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3121 make redirect uri dynamic #2385

Closed
wants to merge 23 commits into from

Conversation

MishNajam
Copy link
Contributor

Purpose

Briefly describe the purpose of the change, and/or link to the JIRA ticket for context

Fixes UML-####

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@MishNajam MishNajam requested a review from a team as a code owner October 26, 2023 16:14
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2385 (ed453e6) into main (cc66851) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2385      +/-   ##
============================================
+ Coverage     92.01%   92.03%   +0.02%     
- Complexity     1459     1463       +4     
============================================
  Files           276      279       +3     
  Lines          6638     6656      +18     
============================================
+ Hits           6108     6126      +18     
  Misses          513      513              
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 88.81% <ø> (ø)
use-an-lpa-api 96.84% <100.00%> (+0.06%) ⬆️
use-an-lpa-front 89.22% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...entication/OneLoginAuthorisationRequestService.php 100.00% <100.00%> (ø)
.../src/App/src/Service/Aws/SecretsManagerFactory.php 100.00% <100.00%> (ø)
...vice-front/app/src/Actor/src/Form/OneLoginForm.php 100.00% <100.00%> (ø)
...rc/Common/src/Service/OneLogin/OneLoginService.php 100.00% <100.00%> (ø)

@MishNajam MishNajam closed this Oct 30, 2023
@MishNajam MishNajam deleted the UML-3121-make-redirect-uri-dynamic branch October 30, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant