-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UML-3034 - banner removed from home page #2380
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntse
force-pushed
the
uml-2876-remove-banner
branch
from
October 25, 2023 17:56
b212e53
to
c2b923c
Compare
Lbagg1
changed the title
UML-2876 - banner removed from home page
UML-3034 - banner removed from home page
Oct 26, 2023
cooperaj
reviewed
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an odd file I don't recognise.
Additionally there is no commited .mo file which I would expect for a .po file change?
cooperaj
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Background:
We tell users on the gov.uk start page that they can’t use the service if their LPA was registered before this date.
Remove the entire banner and the words inside. - see attachment below for the banner.
Acceptance criteria
When the user goes to https://use-lasting-power-of-attorney.service.gov.uk/home they do not see the banner
Any code coverage removed
Fixes UML-3034
Approach
Learning
Checklist
*~ [ ] I have added relevant logging with appropriate levels to my code~
[ ] New event_codes have been documented on the [wiki page]~~(https://opgtransform.atlassian.net/wiki/spaces/LSML2/pages/3277881441/Understanding+the+event+logs)[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant[ ] I have added tests to prove my work[ ] I have added welsh translation tags and updated translation files[ ] I have run an accessibility tool on any pages I have made changes to and fixed any issues found[ ] I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made