Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3034 - banner removed from home page #2380

Merged
merged 12 commits into from
Nov 1, 2023
Merged

Conversation

Lbagg1
Copy link
Contributor

@Lbagg1 Lbagg1 commented Oct 25, 2023

Purpose

Background:

We tell users on the gov.uk start page that they can’t use the service if their LPA was registered before this date.

Remove the entire banner and the words inside. - see attachment below for the banner.

Acceptance criteria

When the user goes to https://use-lasting-power-of-attorney.service.gov.uk/home they do not see the banner

Any code coverage removed

Fixes UML-3034

Approach

Learning

Checklist

  • I have performed a self-review of my own code
    *~ [ ] I have added relevant logging with appropriate levels to my code~
  • [ ] New event_codes have been documented on the [wiki page]~~(https://opgtransform.atlassian.net/wiki/spaces/LSML2/pages/3277881441/Understanding+the+event+logs)
  • [ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • [ ] I have added tests to prove my work
  • [ ] I have added welsh translation tags and updated translation files
  • [ ] I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • [ ] I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@ntse ntse force-pushed the uml-2876-remove-banner branch from b212e53 to c2b923c Compare October 25, 2023 17:56
@Lbagg1 Lbagg1 marked this pull request as ready for review October 26, 2023 08:40
@Lbagg1 Lbagg1 requested a review from a team as a code owner October 26, 2023 08:40
@Lbagg1 Lbagg1 changed the title UML-2876 - banner removed from home page UML-3034 - banner removed from home page Oct 26, 2023
Copy link
Contributor

@cooperaj cooperaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an odd file I don't recognise.

Additionally there is no commited .mo file which I would expect for a .po file change?

service-front/app/languages/.pot Outdated Show resolved Hide resolved
Copy link
Contributor

@cooperaj cooperaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Lbagg1 Lbagg1 merged commit 43fc931 into main Nov 1, 2023
29 checks passed
@Lbagg1 Lbagg1 deleted the uml-2876-remove-banner branch November 1, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants