-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uml 3013 kick off one login process #2369
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2369 +/- ##
============================================
+ Coverage 92.01% 92.03% +0.02%
- Complexity 1459 1463 +4
============================================
Files 276 279 +3
Lines 6638 6655 +17
============================================
+ Hits 6108 6125 +17
Misses 513 513
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e0ce4ec
to
2a6c8c5
Compare
8c370a1
to
1a26695
Compare
service-api/app/src/App/src/Handler/OneLoginAuthorisationRequestHandler.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here I guess (and everywhere else). Sorry, I should have picked this up earlier. PHPStorm refactoring should make it easy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added all these PR changes and have refactored classes and methods.
service-front/app/src/Actor/src/Handler/AuthoriseOneLoginHandler.php
Outdated
Show resolved
Hide resolved
3b46d68
to
4c42e69
Compare
Purpose
Ticket that kicks off the one login authorisation process when clicking on a "Sign in via One Login" button.
This button is on a page behind the ALLOW_GOV_ONE_LOGIN feature flag.
Fixes UML-3013
Approach
Learning
Did not wire in factories as part of previous tickets. Have now wired in factories in the service-api ConfigProvider.php
Checklist