Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uml 3013 kick off one login process #2369

Merged
merged 26 commits into from
Oct 30, 2023
Merged

Conversation

MishNajam
Copy link
Contributor

@MishNajam MishNajam commented Oct 16, 2023

Purpose

Ticket that kicks off the one login authorisation process when clicking on a "Sign in via One Login" button.
This button is on a page behind the ALLOW_GOV_ONE_LOGIN feature flag.

Fixes UML-3013

Approach

  • On dev this will set the homepage to be a temporary onelogin page

Learning

Did not wire in factories as part of previous tickets. Have now wired in factories in the service-api ConfigProvider.php

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@MishNajam MishNajam requested a review from a team as a code owner October 16, 2023 15:52
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2369 (d53a040) into main (c434ccb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2369      +/-   ##
============================================
+ Coverage     92.01%   92.03%   +0.02%     
- Complexity     1459     1463       +4     
============================================
  Files           276      279       +3     
  Lines          6638     6655      +17     
============================================
+ Hits           6108     6125      +17     
  Misses          513      513              
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 88.81% <ø> (ø)
use-an-lpa-api 96.84% <100.00%> (+0.06%) ⬆️
use-an-lpa-front 89.21% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ntication/OneLoginAuthenticationRequestService.php 100.00% <100.00%> (ø)
.../src/App/src/Service/Aws/SecretsManagerFactory.php 100.00% <100.00%> (ø)
...vice-front/app/src/Actor/src/Form/OneLoginForm.php 100.00% <100.00%> (ø)
...rc/Common/src/Service/OneLogin/OneLoginService.php 100.00% <100.00%> (ø)

@MishNajam MishNajam force-pushed the UML-3013-kick-off-one-login-process branch from e0ce4ec to 2a6c8c5 Compare October 25, 2023 09:51
@ntse ntse force-pushed the UML-3013-kick-off-one-login-process branch from 8c370a1 to 1a26695 Compare October 26, 2023 11:45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here I guess (and everywhere else). Sorry, I should have picked this up earlier. PHPStorm refactoring should make it easy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added all these PR changes and have refactored classes and methods.

service-front/docker/app/Dockerfile Outdated Show resolved Hide resolved
@MishNajam MishNajam force-pushed the UML-3013-kick-off-one-login-process branch from 3b46d68 to 4c42e69 Compare October 30, 2023 10:20
@MishNajam MishNajam requested a review from cooperaj October 30, 2023 11:05
@MishNajam MishNajam merged commit 5ae1593 into main Oct 30, 2023
32 checks passed
@MishNajam MishNajam deleted the UML-3013-kick-off-one-login-process branch October 30, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants