Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-2987 Spike PR branch - Not for merge #2330

Closed

Conversation

MishNajam
Copy link
Contributor

Not for Merge

Purpose

Draft spike branch to still show summary page when image extraction service is down.

Fixes UML-3049

Approach

Recreating the error by mocking with the mock-image-request-handler to return a 500 error with an lpa that already existed. Will need to create a new mock lpa in the mock-data-lpa and mock-image-request-handler side.

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@MishNajam MishNajam requested a review from a team as a code owner September 11, 2023 16:44
@MishNajam MishNajam marked this pull request as draft September 11, 2023 17:00
@ntse ntse force-pushed the UML-2986-spike-show-summary-if-image-extraction-fails branch from 5ade1ed to 12d5693 Compare October 26, 2023 11:44
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2330 (12d5693) into main (4b2086c) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2330      +/-   ##
============================================
- Coverage     92.01%   92.00%   -0.02%     
- Complexity     1459     1460       +1     
============================================
  Files           276      276              
  Lines          6638     6639       +1     
============================================
  Hits           6108     6108              
- Misses          513      514       +1     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 88.81% <ø> (ø)
use-an-lpa-api 96.79% <50.00%> (+0.01%) ⬆️
use-an-lpa-front 89.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ice-api/app/src/App/src/Service/Lpa/LpaService.php 98.36% <50.00%> (-0.82%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants