Add XRay SDK to lambda #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can trace calls through to dependent services like DynamoDB Fixes VEGA-2103 #minor
gregtyler
temporarily deployed
to
8vega2103ad popup environment
GitHub Actions
Inactive
Rather than our lambdas depending directly on DynamoDB, we want them to depend on a common interface (`shared.Client`) with generic Put/Get/Patch methods. This allows us more flexibility to change the storage (e.g. between DynamoDB and RDS) without needing to change the compute code. It also allows the "proper" lambda code to focus on its behaviour rather than implementation details. For VEGA-2103 #minor
gregtyler
temporarily deployed
to
8vega2103ad popup environment
GitHub Actions
Inactive
So we don't maintain a long list of old popup environments #patch
gregtyler
temporarily deployed
to
8vega2103ad popup environment
GitHub Actions
Inactive
GemTay
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can trace calls through to dependent services like DynamoDB
This also moves the DynamoDB-specific code into a shared client behind an interface, so that the lambdas depend on a common interface (
shared.Client) with generic Put/Get/Patch methods.This allows us more flexibility to change the storage (e.g. between DynamoDB and RDS) without needing to change the compute code.
It also allows the "proper" lambda code to focus on its behaviour rather than implementation details.
Fixes VEGA-2103 #minor