Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6163 - Add Firehose Resources #6449

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Conversation

mikereiddigital
Copy link
Contributor

@mikereiddigital mikereiddigital commented Mar 12, 2024

A reference to the issue / Description of it

As per issue #6163 - this adds data items, locals and variable assignments to support the creation of AWS Firehose resources in the required environments - development & production. These are required for the transfer of vpc flow log data to the MoJ's SecOps team that will be used for protective monitoring purposes.

How does this PR fix the problem?

The module https://github.com/ministryofjustice/modernisation-platform-terraform-member-vpc has been updated to build these AWS Firehose & associated resources and this change adds the necessary locals, data items and variable assignments to support this for development & production vpcs.

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

This build has been tested in core-vpc-sandbox.

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

This change covers additions only so there will be no impact on existing services.

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ You are making changes to the secrets in the MP platform, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ You are making changes to the secrets in the MP platform, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ You are making changes to the secrets in the MP platform, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

Please check the plan carefully before deploying these changes.

⚠️ You are making changes to the secrets in the MP platform, for more information on the potential impact of these changes consult the documentation.

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

@mikereiddigital mikereiddigital merged commit a6aa3d7 into main Mar 12, 2024
17 checks passed
@mikereiddigital mikereiddigital deleted the adds-firehose-resources branch March 12, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants