Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of dynamodb_table with use_lockfile #9447

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Jan 24, 2025

This PR is tracked upstream by #8345. You can see the context for this PR in the linked issue. In short, though, we know that stale state file locks have been a source of some friction for our customers, and now that a better alternative exists we'd like to implement it for you.

You can see an example of this PR being tested in #9443 .

This PR does the following:

  • Sets the minimum Terraform version to 1.10 in any required_providers {} block as this is the minimum version that allows the use of native S3 state locking
  • Replaces the use of dynamodb_table with use_lockfile in all platform_versions.tf
  • Removes the -backend-config= statements from terraform init steps in our reusable Terraform jobs.

@dms1981 dms1981 requested review from a team as code owners January 24, 2025 15:58
@dms1981 dms1981 requested a deployment to operations-engineering-development January 24, 2025 16:03 — with GitHub Actions Waiting
@dms1981 dms1981 requested a deployment to nomis-data-hub-development January 24, 2025 16:03 — with GitHub Actions Waiting
@dms1981 dms1981 requested a deployment to mojfin-development January 24, 2025 16:03 — with GitHub Actions Waiting
@dms1981 dms1981 requested a deployment to delius-core-development January 24, 2025 16:03 — with GitHub Actions Waiting
Copy link
Contributor

@modernisation-platform-ci modernisation-platform-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform plan evaluation detected changes to resources that require approval from @ministryofjustice/modernsation-platform - please contact #ask-modernisation-platform for assistance

@modernisation-platform-ci
Copy link
Contributor

@dms1981 Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance

Guidance on approving these PRs is available at https://user-guide.modernisation-platform.service.justice.gov.uk/runbooks/reviewing-mp-environments-prs.html#process-for-approving-prs

@dms1981 dms1981 requested a deployment to cdpt-ifs-development January 24, 2025 16:03 — with GitHub Actions Waiting
Copy link
Contributor

@modernisation-platform-ci modernisation-platform-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform plan evaluation detected changes to resources that require approval from @ministryofjustice/modernsation-platform - please contact #ask-modernisation-platform for assistance

@modernisation-platform-ci
Copy link
Contributor

@dms1981 Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance

Guidance on approving these PRs is available at https://user-guide.modernisation-platform.service.justice.gov.uk/runbooks/reviewing-mp-environments-prs.html#process-for-approving-prs

Copy link
Contributor

@modernisation-platform-ci modernisation-platform-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform plan evaluation detected changes to resources that require approval from @ministryofjustice/modernsation-platform - please contact #ask-modernisation-platform for assistance

@modernisation-platform-ci
Copy link
Contributor

@dms1981 Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance

Guidance on approving these PRs is available at https://user-guide.modernisation-platform.service.justice.gov.uk/runbooks/reviewing-mp-environments-prs.html#process-for-approving-prs

@dms1981 dms1981 requested a deployment to portal-development January 24, 2025 16:03 — with GitHub Actions Waiting
@dms1981 dms1981 deployed to hmpps-domain-services-development January 24, 2025 16:03 — with GitHub Actions Active
@dms1981 dms1981 deployed to hmpps-domain-services-test January 24, 2025 16:03 — with GitHub Actions Active
@dms1981 dms1981 requested a deployment to pra-register-development January 24, 2025 16:03 — with GitHub Actions Waiting
@dms1981 dms1981 requested a deployment to laa-ccms-infra-azure-ad-sso-development January 24, 2025 16:03 — with GitHub Actions Waiting
@dms1981 dms1981 requested a deployment to nomis-data-hub-test January 24, 2025 16:04 — with GitHub Actions Waiting
@dms1981 dms1981 requested a deployment to analytical-platform-ingestion-development January 24, 2025 16:04 — with GitHub Actions Waiting
@dms1981 dms1981 requested a deployment to nomis-combined-reporting-test January 24, 2025 16:04 — with GitHub Actions Waiting
@dms1981 dms1981 requested a deployment to nomis-combined-reporting-development January 24, 2025 16:04 — with GitHub Actions Waiting
@dms1981 dms1981 had a problem deploying to ccms-ebs-development January 24, 2025 16:04 — with GitHub Actions Error
@dms1981 dms1981 requested a deployment to hmpps-oem-development January 24, 2025 16:04 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update github-workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants