Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump s3-bucket::modernisation-platform-terraform-s3-bucket from 7.1.0 to 8.0.0 in /terraform/environments/mlra #6887

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 5, 2024

Bumps s3-bucket::modernisation-platform-terraform-s3-bucket from 7.1.0 to 8.0.0.

Release notes

Sourced from s3-bucket::modernisation-platform-terraform-s3-bucket's releases.

v8.0.0

Breaking Changes

Module for creating IAM role for replication has been integrated into this S3-bucket module so includes functionality for an IAM role to enable the replication of objects between S3 buckets in different regions.

The breaking changes only apply to pre existing replication buckets, used by this module here. If you currently do not use the replication module, you will not be affected.

  • 'versioning_enabled' is not optional and must be set to true for both source and destination bucket.
  • 'ownership_controls' variable must be set to 'BucketOwnerEnforced' for full control of all objects in the bucket and to disable ACLs.
  • The KMS key used for encryption must be in the same region as the destination bucket.

If any more information is required, feel free to reach out to Khatra Farah or Edd Proctor.

What's Changed

... (truncated)

Commits
  • cadab51 Merge pull request #446 from ministryofjustice/test/s3-replication
  • 26143c6 Commit changes made by code formatters
  • 25e42ee terraform-docs: automated action
  • 19968ac more changes to enable integration of replication role module into the s3 buc...
  • 08263e7 Merge pull request #445 from ministryofjustice/dependabot/github_actions/gith...
  • 114ab56 Bump github/codeql-action from 3.25.7 to 3.25.8
  • 0b7ae44 Merge pull request #442 from ministryofjustice/dependabot/github_actions/terr...
  • f72dcef Merge pull request #444 from ministryofjustice/dependabot/github_actions/brid...
  • dc6715e Bump bridgecrewio/checkov-action from 12.2768.0 to 12.2769.0
  • 31806f8 Merge pull request #443 from ministryofjustice/dependabot/github_actions/brid...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [s3-bucket::modernisation-platform-terraform-s3-bucket](https://github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket) from 7.1.0 to 8.0.0.
- [Release notes](https://github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket/releases)
- [Commits](ministryofjustice/modernisation-platform-terraform-s3-bucket@v7.1.0...v8.0.0)

---
updated-dependencies:
- dependency-name: s3-bucket::github::ministryofjustice/modernisation-platform-terraform-s3-bucket::v7.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code labels Jul 5, 2024
@dependabot dependabot bot requested review from a team as code owners July 5, 2024 00:24
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/mlra/modules/alb


Running Trivy in terraform/environments/mlra/modules/alb
2024-07-05T00:26:46Z INFO Need to update DB
2024-07-05T00:26:46Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-07-05T00:26:49Z INFO Vulnerability scanning is enabled
2024-07-05T00:26:49Z INFO Misconfiguration scanning is enabled
2024-07-05T00:26:49Z INFO Need to update the built-in policies
2024-07-05T00:26:49Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-07-05T00:26:49Z INFO Secret scanning is enabled
2024-07-05T00:26:49Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-05T00:26:49Z INFO Please see also https://aquasecurity.github.io/trivy/v0.53/docs/scanner/secret#recommendation for faster secret detection
2024-07-05T00:26:50Z INFO Number of language-specific files num=0
2024-07-05T00:26:50Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/mlra/modules/alb

*****************************

Running Checkov in terraform/environments/mlra/modules/alb
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-07-05 00:26:53,384 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v8.0.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 48, Failed checks: 0, Skipped checks: 21


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/mlra/modules/alb

*****************************

Running tflint in terraform/environments/mlra/modules/alb
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/environments/mlra/modules/alb

*****************************

Running Trivy in terraform/environments/mlra/modules/alb
2024-07-05T00:26:46Z	INFO	Need to update DB
2024-07-05T00:26:46Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-07-05T00:26:49Z	INFO	Vulnerability scanning is enabled
2024-07-05T00:26:49Z	INFO	Misconfiguration scanning is enabled
2024-07-05T00:26:49Z	INFO	Need to update the built-in policies
2024-07-05T00:26:49Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-07-05T00:26:49Z	INFO	Secret scanning is enabled
2024-07-05T00:26:49Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-07-05T00:26:49Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.53/docs/scanner/secret#recommendation for faster secret detection
2024-07-05T00:26:50Z	INFO	Number of language-specific files	num=0
2024-07-05T00:26:50Z	INFO	Detected config files	num=3
trivy_exitcode=0

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Aug 5, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 16, 2024

Superseded by #7475.

@dependabot dependabot bot closed this Aug 16, 2024
@dependabot dependabot bot deleted the dependabot/terraform/terraform/environments/mlra/s3-bucket--github--ministryofjustice/modernisation-platform-terraform-s3-bucket--v7.1.0-8.0.0 branch August 16, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file environments-repository Used to exclude PRs from this repo in our Slack PR update Stale terraform Pull requests that update Terraform code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants