Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pfm/dsos 2216/security groups #3622

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Pfm/dsos 2216/security groups #3622

merged 4 commits into from
Oct 10, 2023

Conversation

robertsweetman
Copy link
Contributor

  • loadbalancer, web, app, domain and jumpserver sg's ready for new instances
  • further work will be needed once we add 'external access' but this is a good enough initial framework
  • remove duplicate/un-used data-db SG before it's attached to things in anger

@robertsweetman robertsweetman requested review from a team as code owners October 10, 2023 12:58
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Oct 10, 2023
@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

drobinson-moj
drobinson-moj previously approved these changes Oct 10, 2023
View reviewed changes
@robertsweetman robertsweetman force-pushed the pfm/DSOS-2216/security-groups branch from 2549f16 to 71c1bc9 Compare October 10, 2023 13:30
@robertsweetman robertsweetman temporarily deployed to planetfm-test October 10, 2023 13:32 — with GitHub Actions Inactive
@robertsweetman robertsweetman temporarily deployed to planetfm-development October 10, 2023 13:32 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

2 similar comments
@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@robertsweetman robertsweetman merged commit a96d23f into main Oct 10, 2023
@robertsweetman robertsweetman deleted the pfm/DSOS-2216/security-groups branch October 10, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASTRobinson ASTRobinson ASTRobinson approved these changes

@drobinson-moj drobinson-moj drobinson-moj left review comments

Assignees
No one assigned
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertsweetman @ASTRobinson @drobinson-moj