Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new DNS for User Guidance #3540

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Adding new DNS for User Guidance #3540

merged 1 commit into from
Oct 3, 2023

Conversation

jhpyke
Copy link
Contributor

@jhpyke jhpyke commented Oct 3, 2023

This PR adds a new sub-domain for User Guidance in Data Platform

@jhpyke jhpyke requested review from a team October 3, 2023 12:22
@jhpyke jhpyke requested review from a team as code owners October 3, 2023 12:22
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Oct 3, 2023
jacobwoffenden
jacobwoffenden approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@jacobwoffenden jacobwoffenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GREAT to me

@jhpyke jhpyke had a problem deploying to data-platform-test October 3, 2023 12:23 — with GitHub Actions Failure
@jhpyke jhpyke had a problem deploying to data-platform-development October 3, 2023 12:24 — with GitHub Actions Failure
@jhpyke jhpyke merged commit b1ae491 into main Oct 3, 2023
8 of 10 checks passed
@jhpyke jhpyke deleted the create-DNS-for-User-Guidance branch October 3, 2023 12:25
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobwoffenden jacobwoffenden jacobwoffenden approved these changes

Assignees
No one assigned
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhpyke @jacobwoffenden