Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dev jumpservers to rdp port allow range, fix ldap and netbios rules #3298

Merged
merged 9 commits into from
Sep 6, 2023
Merged

add dev jumpservers to rdp port allow range, fix ldap and netbios rules #3298

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cce608f
add dev jumpservers to rdp port allow range, fix ldap and netbios rules
robertsweetman Sep 6, 2023
82adf82
add RDGateway subnet
robertsweetman Sep 6, 2023
2fb51e9
rename
robertsweetman Sep 6, 2023
df8a3d3
there's 2 of them
robertsweetman Sep 6, 2023
395f83d
change name to debug issue
robertsweetman Sep 6, 2023
4ddccf9
change name to trigger plan
robertsweetman Sep 6, 2023
120d080
delete rules
robertsweetman Sep 6, 2023
8cd2aff
comment back in
robertsweetman Sep 6, 2023
c667ce2
comment out problematic rules
robertsweetman Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 9 additions & 26 deletions terraform/environments/corporate-staff-rostering/locals_security_groups.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ locals {
module.ip_addresses.azure_fixngo_cidrs.internet_egress,
])
rdp = {
inbound = ["10.40.165.0/26", "10.112.3.0/26", "10.102.3.0/26"]
inbound = ["10.40.165.0/26", "10.112.3.0/26", "10.102.3.0/26", "10.102.1.64/26", "10.102.0.128/26"]
}
oracle_db = flatten([
module.ip_addresses.azure_fixngo_cidrs.devtest,
Expand Down Expand Up @@ -141,27 +141,19 @@ locals {
cidr_blocks = [for ip in module.ip_addresses.azure_fixngo_ips.devtest.domain_controllers : "${ip}/32"]
security_groups = []
}
/* netbios = { FIXME: add this back in
/* netbios = {
description = "Allow ingress Azure domain controllers"
from_port = 137
to_port = 139
protocol = -1
cidr_blocks = [for ip in module.ip_addresses.azure_fixngo_ips.devtest.domain_controllers : "${ip}/32"]
security_groups = []
} */
/* ldap = { FIXME: add this back in
description = "Allow ingress Azure domain controllers"
from_port = 389
to_port = 389
protocol = "TCP"
cidr_blocks = [for ip in module.ip_addresses.azure_fixngo_ips.devtest.domain_controllers : "${ip}/32"]
security_groups = []
}
ldap_udp = {
description = "Allow ingress Azure domain controllers"
ldap = {
description = "Allow LDAP ingress from Azure domain controllers"
from_port = 389
to_port = 389
protocol = "UDP"
protocol = -1
cidr_blocks = [for ip in module.ip_addresses.azure_fixngo_ips.devtest.domain_controllers : "${ip}/32"]
security_groups = []
} */
Expand Down Expand Up @@ -328,28 +320,19 @@ locals {
cidr_blocks = [for ip in module.ip_addresses.azure_fixngo_ips.devtest.domain_controllers : "${ip}/32"]
security_groups = []
}
/* } FIXME: add this back in
netbios = {
/* netbios = {
description = "Allow ingress Azure domain controllers"
from_port = 137
to_port = 139
protocol = -1
cidr_blocks = [for ip in module.ip_addresses.azure_fixngo_ips.devtest.domain_controllers : "${ip}/32"]
security_groups = []
} */
/* ldap = { FIXME: add this back in
description = "Allow ingress Azure domain controllers"
from_port = 389
to_port = 389
protocol = "TCP"
cidr_blocks = [for ip in module.ip_addresses.azure_fixngo_ips.devtest.domain_controllers : "${ip}/32"]
security_groups = []
}
ldap_udp = {
description = "Allow ingress Azure domain controllers"
ldap = {
description = "Allow LDAP ingress from Azure domain controllers"
from_port = 389
to_port = 389
protocol = "UDP"
protocol = -1
cidr_blocks = [for ip in module.ip_addresses.azure_fixngo_ips.devtest.domain_controllers : "${ip}/32"]
security_groups = []
} */
Expand Down