[DPR2-1576] Linting

ministryofjustice · Jan 6, 2025 · d8aa2c6 · d8aa2c6
1 parent 5a14c3b
commit d8aa2c6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/terraform/environments/digital-prison-reporting/modules/s3_bucket/main.tf b/terraform/environments/digital-prison-reporting/modules/s3_bucket/main.tf
@@ -32,6 +32,8 @@ resource "aws_s3_bucket_public_access_block" "storage" {
 }
 
 resource "aws_s3_bucket_lifecycle_configuration" "lifecycle" {
+  #checkov:skip=CKV_AWS_300:TODO Will be addressed as part of https://dsdmoj.atlassian.net/browse/DPR2-1083
+
   # Create the lifecycle configuration if either lifecycle or Intelligent-Tiering is enabled
   count = var.enable_lifecycle || var.enable_intelligent_tiering ? 1 : 0
 

diff --git a/terraform/environments/digital-prison-reporting/modules/s3_bucket/variables.tf b/terraform/environments/digital-prison-reporting/modules/s3_bucket/variables.tf
@@ -25,6 +25,7 @@ variable "cloudtrail_access_policy" {
 
 variable "s3_notification_name" {
   description = "S3 Notification Event Name"
+  type        = string
   default     = "s3-notification-event"
 }